Solve loading of letters#2
Open
leviathanch wants to merge 2 commits into
Open
Conversation
added 2 commits
July 25, 2025 15:17
The letter element dictionary had not been initialized properly, this patch makes sure that the dict has been initialized, preventing crashes in lctime
NGSpice now writes warnings to stderror apparently. In order to keep going when trying to characterize our cells with CharLib, I need to discard some errors when the slew rate is too small in some circumstances.
infinitymdm
requested changes
Oct 2, 2025
Owner
There was a problem hiding this comment.
I'd prefer to keep the old import structure if possible, and instead use ElementData.elements or ElementData._init on L318-320.
| elif 'doAnalyses' in content: | ||
| func = self._logger.info | ||
| elif 'run simulation(s) aborted' in content: | ||
| func = self._logger.info |
Owner
There was a problem hiding this comment.
This seems like it should probably be at least a .warning, if not .error. Or is there a case where it's ok if the simulations are aborted?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The letter element dictionary had not been initialized properly, this patch makes sure that the dict has been initialized, preventing crashes in lctime
I have now tracked down the error and introduced a proper fix