Skip to content

Solve loading of letters #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leviathanch wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solve loading of letters #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e54d6a6
Solve loading of letters
Jul 25, 2025
7df3580
Catching more stderror outputs
Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions PySpice/Spice/NgSpice/Shared.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,6 +627,10 @@ def _send_char(message_c, ngspice_id, user_data):
func = self._logger.warning
elif 'Note:' in content:
func = self._logger.info
elif 'doAnalyses' in content:
Comment thread
infinitymdm marked this conversation as resolved.
func = self._logger.info
elif 'run simulation(s) aborted' in content:
func = self._logger.info

@infinitymdm infinitymdm Oct 2, 2025

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it should probably be at least a .warning, if not .error. Or is there a case where it's ok if the simulations are aborted?

else:
self._error_in_stderr = True
func = self._logger.error
Expand Down
8 changes: 6 additions & 2 deletions PySpice/Spice/Parser/HighLevelParser.py
View file
Open in desktop

@infinitymdm infinitymdm Oct 2, 2025

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to keep the old import structure if possible, and instead use ElementData.elements or ElementData._init on L318-320.

Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,9 @@
from ..Netlist import Node
from ..StringTools import remove_multi_space
from . import Ast
from . import ElementData
from PySpice.Spice.Parser.ElementData import elements as ElementData_elements
from PySpice.Spice.Parser.ElementData import _init as ElementData_init

from .Ast import AstNode
from .Parser import SpiceParser
from .SpiceSyntax import ElementLetters
Expand Down Expand Up @@ -313,7 +315,9 @@ def __init__(self, line: SpiceLine, ast: AstNode) -> None:
# Read nodes
self._nodes = []
number_of_pins = 0
data = ElementData.elements[self._letter]
if(len(ElementData_elements)==0):
ElementData_init()
data = ElementData_elements[self._letter]
if not data.has_variable_number_of_pins:
number_of_pins = data.number_of_pins
else: # Q or X
Expand Down