Skip to content

Package upgrades and build issue fixes#189

Merged
mtmacdonald merged 8 commits into
masterfrom
build-fixes
Jan 15, 2026
Merged

Package upgrades and build issue fixes#189
mtmacdonald merged 8 commits into
masterfrom
build-fixes

Conversation

@mtmacdonald

@mtmacdonald mtmacdonald commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

Upgrades packages and attempts to work through build-related issues.

Resolved 🟢

  • Upgrade all NPM packages to latest versions
  • Regenerate yarn.lock from scratch (rm yarn.lock && yarn install) since some old versions of dependencies were still being pulled in
  • Reverse the workaround minify: false from PR188. There is a better fix for #187. The oxc team answered in MR7855. The resolution was upgrading to vite 8.0.0-beta.8 including by regeneration of yarn.lock, followed by working through other issues related to plugin configs
  • Improved vite-plugin-node-polyfills configuration (I got further on two issues, but removed package due to others, see below)
    • Removed the manual resolve configs, prompted by this reply
    • No longer blocked by #143 💪 (can't access lexical declaration '__buffer_polyfill' before initialization)

Remaining issues with vite-plugin-node-polyfills 🟠

  • Production build (yarn build:docs) is back to showing Buffer is not defined at runtime 😞 No point using the plugin for now if we can only get it working in development builds.
Screenshot 2026-01-15 at 18 40 38
  • I also still get build warnings related to vite-plugin-node-polyfills. I think we could live with them short-term until the Vite 8 rollout and community packages are more finalised.

  • #142

    • warning: esbuild option was specified by "vite-plugin-node-polyfills" plugin. This option is deprecated, please use oxc instead
    • Both esbuild and oxc options were set. oxc options will be used and esbuild options will be ignored
Screenshot 2026-01-13 at 20 08 59 Screenshot 2026-01-13 at 20 28 30
  • We also have a dependabot warning #38 to resolve, that's pulled in by vite-plugin-node-polyfills. Looks like there is no fix yet - all known versions of elliptic package have this. Follow #344 and #144.

Conclusion

All packages are upgraded to latest versions, but I'm removing vite-plugin-node-polyfills until upstream issues are resolved. We can live with the Buffer is not defined runtime console warning from react-pdf - the app still functions.

@mtmacdonald mtmacdonald merged commit 292914f into master Jan 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant