Skip to content

Fix reactiveVal bug with latest shiny release#688

Open
averissimo wants to merge 3 commits into
mainfrom
682_fix_shiny_round_2
Open

Fix reactiveVal bug with latest shiny release#688
averissimo wants to merge 3 commits into
mainfrom
682_fix_shiny_round_2

Conversation

@averissimo

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename                        Stmts    Miss  Cover    Missing
----------------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------
R/calls_combine_by.R                7       0  100.00%
R/choices_labeled.R                23       1  95.65%   34
R/count_labels.R                  126       0  100.00%
R/filter_panel_api.R               27       1  96.30%   132
R/FilteredData-utils.R             58       0  100.00%
R/FilteredData.R                  522      22  95.79%   109, 138, 186, 325, 397, 484-493, 514, 610-613, 657, 873
R/FilteredDataset-utils.R          23       1  95.65%   125
R/FilteredDataset.R               264       3  98.86%   49, 154, 189
R/FilteredDatasetDataframe.R      123       3  97.56%   87, 148, 158
R/FilteredDatasetDefault.R         18       0  100.00%
R/FilteredDatasetMAE.R            133      15  88.72%   56, 118-123, 160-165, 169-170
R/FilterPanelAPI.R                 10       0  100.00%
R/FilterState-utils.R             101       2  98.02%   264, 294
R/FilterState.R                   366      21  94.26%   90, 154, 265-266, 272-273, 327, 329, 415, 631, 674-678, 697, 761-767, 778
R/FilterStateChoices.R            354      10  97.18%   325, 448-451, 563-566, 611
R/FilterStateDate.R               221      46  79.19%   233, 361-371, 382-387, 391-396, 404-419, 438-445
R/FilterStateDatettime.R          316     125  60.44%   269, 389-530
R/FilterStateEmpty.R               53      22  58.49%   89, 100-104, 117, 146-162
R/FilterStateExpr.R                81       1  98.77%   244
R/FilterStateLogical.R            201      84  58.21%   139, 161, 221, 228, 248, 294-388
R/FilterStateRange.R              411     121  70.56%   264, 386, 497-504, 507-517, 520, 531-537, 548-560, 564-574, 578-580, 593-619, 634-641, 644-651, 665-682, 717-722, 732-734
R/FilterStates-utils.R             70       7  90.00%   108, 127, 188-194
R/FilterStates.R                  379      19  94.99%   63, 92-96, 208, 425, 470, 559-563, 608, 726-729
R/FilterStatesDF.R                  5       0  100.00%
R/FilterStatesMAE.R                10       1  90.00%   40
R/FilterStatesMatrix.R              7       0  100.00%
R/FilterStatesSE.R                171      47  72.51%   36, 73-75, 85-87, 119, 191-201, 213-223, 230-237, 245-252, 259
R/include_css_js.R                  5       0  100.00%
R/teal_slice.R                    108       1  99.07%   206
R/teal_slices.R                    88       5  94.32%   152-157
R/test_utils.R                     21       0  100.00%
R/utils.R                          29       0  100.00%
R/variable_types.R                 15       1  93.33%   48
R/zzz.R                            16      16  0.00%    3-46
TOTAL                            4362     575  86.82%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 36d43a2

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Unit Tests Summary

  1 files   32 suites   41s ⏱️
476 tests 461 ✅ 15 💤 0 ❌
978 runs  963 ✅ 15 💤 0 ❌

Results for commit 36d43a2.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
FilteredData 💔 $20.44$ $+1.58$ $0$ $0$ $0$ $0$

Results for commit c44a483

♻️ This comment has been updated with latest results.

@llrs-roche llrs-roche left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with examples on teal.osprey I haven't found any other reactiveVal outside a reactive environment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Heads-up: shiny session cleanup will affect teal_slice tests (temporarily deferred for 1.14.0)

2 participants