Skip to content

Fix reactiveVal bug with latest shiny release #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
averissimo wants to merge 3 commits into
base: main
Choose a base branch
from
+3 −4
Open

Fix reactiveVal bug with latest shiny release #688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
540b946
fix: use withReactiveNull on other constructors
averissimo Jul 22, 2026
b4ad3b0
fix: another instance
averissimo Jul 23, 2026
36d43a2
[skip style] [skip vbump] Restyle files
github-actions[bot] Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions R/FilterState.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ FilterState <- R6::R6Class( # nolint

# public methods ----
public = list(

#' @description
#' Initialize a `FilterState` object.
#'
Expand Down Expand Up @@ -107,7 +106,7 @@ FilterState <- R6::R6Class( # nolint
varlabel
}

private$state_history <- reactiveVal(list())
private$state_history <- withReactiveDomain(NULL, reactiveVal(list()))

invisible(self)
})
Expand Down
2 changes: 1 addition & 1 deletion R/FilterStates.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ FilterStates <- R6::R6Class( # nolint
}
private$data <- data
private$data_reactive <- data_reactive
private$state_list <- reactiveVal()
private$state_list <- withReactiveDomain(NULL, reactiveVal())

# Clears state list when finalizing the object
private$session_bindings[["clear_state_list"]] <- list(
Expand Down
2 changes: 1 addition & 1 deletion R/FilteredDataset.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ FilteredDataset <- R6::R6Class( # nolint
logger::log_debug("Instantiating { class(self)[1] }, dataname: { dataname }")
checkmate::assert_character(keys, any.missing = FALSE)
checkmate::assert_character(label, null.ok = TRUE)
private$allow_add <- reactiveVal(TRUE)
private$allow_add <- withReactiveDomain(NULL, reactiveVal(TRUE))
private$dataset <- dataset
private$dataname <- dataname
private$keys <- keys
Expand Down
Loading