Update to Jetty, introduce flowstate_ros_gz_bridge#105
Update to Jetty, introduce flowstate_ros_gz_bridge#105luca-della-vedova wants to merge 21 commits intomainfrom
Conversation
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@google.com>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
iche033
left a comment
There was a problem hiding this comment.
Nice! I was able to follow the instructions to sideload it into a flowstate solution and confirmed that messages are coming through on the /clock.
I left some minor comments. I think it also helps to add the instructions you have in the PR description to a README file?
| <version>0.0.1</version> | ||
| <description>Version of ROS GZ bridge to bridge with Flowstate Gazebo</description> | ||
| <maintainer email="lucadv@intrinsic.ai">Luca Della Vedova</maintainer> | ||
| <license>Intrinsic License</license> |
There was a problem hiding this comment.
I see Intrinsic License used in different package.xml files in this PR. should Apache-2.0 be used instead?
There was a problem hiding this comment.
@wjwwood, we're talking about the license offline. This package uses sim_connection.cc and sim_connection.hh which are adapted from code in insrc (which we eventually want to make public). Do you know if there is process to go through to ensure we can use Apache-2.0, or if there is an appropriate license to use?
There was a problem hiding this comment.
I don't know what process you need to go through. We just got permission to change the license at some point for all of sdk-ros. @tfoote would know maybe?
I don't think it should be merged here until the license is apache-2.0.
There was a problem hiding this comment.
You should also have a LICENSE file in each new package.
There was a problem hiding this comment.
@tfoote, any advice on how we can proceed here? Is it ok to use Apache-2.0 license?
There was a problem hiding this comment.
Updated to Apache 2.0 since it's a fairly trivial piece of code that we intend to make public anyway in dd84f41
There was a problem hiding this comment.
Yes, please use Apache-2.0 for this packages and files to be consistent with the rest of the repo.
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Yap good point, added in 0f48753 |
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
wjwwood
left a comment
There was a problem hiding this comment.
Need to resolve the license before merging.
| <version>0.0.1</version> | ||
| <description>Version of ROS GZ bridge to bridge with Flowstate Gazebo</description> | ||
| <maintainer email="lucadv@intrinsic.ai">Luca Della Vedova</maintainer> | ||
| <license>Intrinsic License</license> |
There was a problem hiding this comment.
You should also have a LICENSE file in each new package.
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Overview
This PR updates the version of the vendored gz packages to target Gazebo Jetty, as well as introduce a vendored
ros_gz_bridge(I believe we need to vendor it because we want to build against custom versions ofgz_transport,gz_msgs), as well as aflowstate_ros_gz_bridgeservice built on top of it that can be used to bridge between the Gazebo running in Flowstate and the user's machine.I had to update the dockerfile for services slightly to make sure that system dependencies installed through
rosdep installare available in the image that is used to run the service. I did so by doingdpkg --get-selectionsas suggested by @wjwwood .The bridge has a default configuration to bridge the clock into ROS to run node in simulation time, but the configuration can be set through the proto when instancing it.
Test it!
The testing involves building the
flowstate_ros_gz_bridgeservice and checking that the clock is successfully bridged:Then instantiate it either from a terminal or the flowstate UI, on a third machine:
You should see the clock topic being bridged to your local machine!