fix: use MediaStreamTrack.findOrCreate() to prevent duplicate track objects losing onended callback#12
Draft
Copilot wants to merge 3 commits into
Draft
fix: use MediaStreamTrack.findOrCreate() to prevent duplicate track objects losing onended callback#12Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Agent-Logs-Url: https://github.com/iotum/cordova-plugin-iosrtc/sessions/e9cc665f-c743-4dcf-9087-941f6a105303 Co-authored-by: rex-iotum <64922037+rex-iotum@users.noreply.github.com>
…bjects losing onended callback Agent-Logs-Url: https://github.com/iotum/cordova-plugin-iosrtc/sessions/e9cc665f-c743-4dcf-9087-941f6a105303 Co-authored-by: rex-iotum <64922037+rex-iotum@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
rex-iotum
March 30, 2026 22:29
View session
Agent-Logs-Url: https://github.com/iotum/cordova-plugin-iosrtc/sessions/0522bf3f-b64f-4131-bdfc-8e2a36d0be63 Co-authored-by: rex-iotum <64922037+rex-iotum@users.noreply.github.com>
|
Context: There is a desync between iosrtc native and facetalk JS when the MediaStream is torn down and MediaStreamTracks are stopped. It does not emit any events to the JS context. This is an attempt to emit and update the JS for any changes. So after hold the This is also optional. We don't need it, it'll just be good for the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MediaStreamTrack.findOrCreate()inMediaStream.create()(audio + video loops)MediaStreamTrack.findOrCreate()inMediaStream.jsonEventaddtrackcaseMediaStreamTrack.findOrCreate()inRTCPeerConnection.jsonEventtrackcasewww/cordova-plugin-iosrtc.jsupdated — only the 4 bug-fix lines changed, no unrelateddebug()library changes