Skip to content

fix: use MediaStreamTrack.findOrCreate() to prevent duplicate track objects losing onended callback #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

fix: use MediaStreamTrack.findOrCreate() to prevent duplicate track objects losing onended callback #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a75462
placeholder
Copilot Mar 30, 2026
44706f5
fix: use MediaStreamTrack.findOrCreate() to prevent duplicate track o…
Copilot Mar 30, 2026
9b45ada
fix: remove unrelated debug() library changes from www bundle
Copilot Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions js/MediaStream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ MediaStream.create = function (dataFromEvent) {

for (trackId in dataFromEvent.audioTracks) {
if (dataFromEvent.audioTracks.hasOwnProperty(trackId)) {
track = new MediaStreamTrack(dataFromEvent.audioTracks[trackId]);
track = MediaStreamTrack.findOrCreate(dataFromEvent.audioTracks[trackId]);

stream._audioTracks[track.id] = track;

Expand All @@ -194,7 +194,7 @@ MediaStream.create = function (dataFromEvent) {

for (trackId in dataFromEvent.videoTracks) {
if (dataFromEvent.videoTracks.hasOwnProperty(trackId)) {
track = new MediaStreamTrack(dataFromEvent.videoTracks[trackId]);
track = MediaStreamTrack.findOrCreate(dataFromEvent.videoTracks[trackId]);

stream._videoTracks[track.id] = track;

Expand Down Expand Up @@ -462,7 +462,7 @@ function onEvent(data) {
track = this._videoTracks[data.track.id];
}
if (!track) {
track = new MediaStreamTrack(data.track);
track = MediaStreamTrack.findOrCreate(data.track);
if (track.kind === 'audio') {
this._audioTracks[track.id] = track;
} else if (track.kind === 'video') {
Expand Down
2 changes: 1 addition & 1 deletion js/RTCPeerConnection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,7 +957,7 @@ function onEvent(data) {
break;

case 'track':
var track = (event.track = new MediaStreamTrack(data.track));
var track = (event.track = MediaStreamTrack.findOrCreate(data.track));
event.receiver = new RTCRtpReceiver(self, { track: track });

transceiver = this.transceivers.find((t) => t.receiver.track.id === track.id);
Expand Down
8 changes: 4 additions & 4 deletions www/cordova-plugin-iosrtc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ MediaStream.create = function (dataFromEvent) {

for (trackId in dataFromEvent.audioTracks) {
if (dataFromEvent.audioTracks.hasOwnProperty(trackId)) {
track = new MediaStreamTrack(dataFromEvent.audioTracks[trackId]);
track = MediaStreamTrack.findOrCreate(dataFromEvent.audioTracks[trackId]);

stream._audioTracks[track.id] = track;

Expand All @@ -399,7 +399,7 @@ MediaStream.create = function (dataFromEvent) {

for (trackId in dataFromEvent.videoTracks) {
if (dataFromEvent.videoTracks.hasOwnProperty(trackId)) {
track = new MediaStreamTrack(dataFromEvent.videoTracks[trackId]);
track = MediaStreamTrack.findOrCreate(dataFromEvent.videoTracks[trackId]);

stream._videoTracks[track.id] = track;

Expand Down Expand Up @@ -667,7 +667,7 @@ function onEvent(data) {
track = this._videoTracks[data.track.id];
}
if (!track) {
track = new MediaStreamTrack(data.track);
track = MediaStreamTrack.findOrCreate(data.track);
if (track.kind === 'audio') {
this._audioTracks[track.id] = track;
} else if (track.kind === 'video') {
Expand Down Expand Up @@ -2875,7 +2875,7 @@ function onEvent(data) {
break;

case 'track':
var track = (event.track = new MediaStreamTrack(data.track));
var track = (event.track = MediaStreamTrack.findOrCreate(data.track));
event.receiver = new RTCRtpReceiver(self, { track: track });

transceiver = this.transceivers.find((t) => t.receiver.track.id === track.id);
Expand Down