On OpenShift pass 1.3 ciphersuites through proxy metadata - #2227
Merged
Conversation
Collaborator
|
Skipping CI for Draft Pull Request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2227 +/- ##
==========================================
+ Coverage 87.81% 87.99% +0.18%
==========================================
Files 56 56
Lines 2658 2665 +7
==========================================
+ Hits 2334 2345 +11
+ Misses 324 320 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
nrfox
force-pushed
the
pass-ciphers-to-envoy
branch
3 times, most recently
from
August 6, 2026 18:26
23be3fb to
15277a5
Compare
nrfox
marked this pull request as ready for review
August 10, 2026 20:04
nrfox
force-pushed
the
pass-ciphers-to-envoy
branch
from
August 11, 2026 20:36
7b97c9a to
c13cc5d
Compare
Contributor
Author
|
/retest |
mkralik3
reviewed
Aug 24, 2026
| originalTLSAdherence := apiServer.Spec.TLSAdherence | ||
|
|
||
| DeferCleanup(func(ctx SpecContext) { | ||
| Step("Restoring the original APIServer TLS settings") |
Contributor
There was a problem hiding this comment.
@nrfox why was this deleted? Doesn't the change on the cluster made during this test influence further tests execution? (e.g., Istio integration)
nrfox
force-pushed
the
pass-ciphers-to-envoy
branch
2 times, most recently
from
August 31, 2026 17:01
5fa3231 to
f868a39
Compare
Envoy does not allow setting cipher suites for TLS 1.3 BUT you can configure them in openssl when that is your crypto backend. The openshift envoy image has been updated to allow configuring these via env var. Signed-off-by: Nick Fox <nfox@redhat.com>
nrfox
force-pushed
the
pass-ciphers-to-envoy
branch
from
August 31, 2026 17:03
f868a39 to
2c8ae19
Compare
Contributor
|
/retest |
Contributor
|
/test lint |
dgn
reviewed
Sep 1, 2026
| // Test 1 runs on all OpenShift clusters. Tests 2 and 3 require OpenShift >= 4.22 | ||
| // The first test runs on all OpenShift clusters; the second requires OpenShift >= 4.22 | ||
| // because the TLSAdherence field was introduced in 4.22. | ||
| // NOTE: Running this test may have side effects such as setting feature gates on OpenShift. |
Collaborator
There was a problem hiding this comment.
I feel like we should log this prominently instead of commenting
Collaborator
There was a problem hiding this comment.
we can do that in a follow-up though
dgn
approved these changes
Sep 1, 2026
Collaborator
|
/retest |
Contributor
Author
|
/cherry-pick release-1.31 |
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Sep 3, 2026
* upstream/main: Make PREVENT_IMAGE_OVERWRITE configurable in release workflow (istio-ecosystem#2305) Pass 1.3 ciphersuites through proxy metadata (istio-ecosystem#2227) Make bundle-publish idempotent by reusing existing PRs (istio-ecosystem#2302) Fix linter errors
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Sep 4, 2026
* upstream/main: Make PREVENT_IMAGE_OVERWRITE configurable in release workflow (istio-ecosystem#2305) Pass 1.3 ciphersuites through proxy metadata (istio-ecosystem#2227) Make bundle-publish idempotent by reusing existing PRs (istio-ecosystem#2302) Fix linter errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Envoy does not allow setting cipher suites for TLS 1.3 BUT you can configure them in openssl when that is your crypto backend. The openshift envoy image has been updated to allow configuring these via env var.
Which issue(s) this PR fixes:
Fixes #
Related Issue/PR #
Additional information: