Log warning - #2308
Merged
Merged
Conversation
Provides more obvious warning to users about side effects than just a comment. Signed-off-by: Nick Fox <nfox@redhat.com>
6 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2308 +/- ##
==========================================
+ Coverage 87.91% 88.06% +0.15%
==========================================
Files 56 56
Lines 2665 2665
==========================================
+ Hits 2343 2347 +4
+ Misses 322 318 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dgn
approved these changes
Sep 3, 2026
Collaborator
|
/retest |
1 similar comment
Collaborator
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides more obvious warning to users about side effects than just a comment.
What type of PR is this?
What this PR does / why we need it:
Follow up to: #2227 (comment)
Which issue(s) this PR fixes:
Fixes #
Related Issue/PR #
Additional information: