Fix/bugfixes and code quality - #3
Merged
Merged
Conversation
…uage detection - Fix files command ignoring user-provided CLI paths (was always scanning cwd) - Fix CStyleClassifier misclassifying inline /* */ comments as pure Comment - Fix PythonClassifier misclassifying triple-quotes with trailing code as Docstring - Add Rust (.rs), YAML (.yml/.yaml), TOML (.toml) language detection - Map Dockerfile/Makefile to Shell language classification - Remove unimplemented History command stub from CLI
…ly code quality fixes - Replace std::process::exit() with Result<ExitCode> pattern in main() - Extract aggregate_stats() to stats.rs for shared use by report and threshold checks - Fix threshold aggregation missing removed/comment/docstring/blank fields - Fix JSON output silently swallowing serialization errors - Fix CI mode appending summary line after JSON (breaking parsers) - Apply clippy fixes: uninlined format args, #[must_use], const fn constructors - Replace wildcard import colored::* with explicit Colorize - Fix usize→i64 casts with TryFrom to prevent wrap on 64-bit targets - Use let-else patterns, nested or-patterns, and move use statements to top
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 6 critical bugs and applies comprehensive code quality improvements following Rust best practices.
Bug Fixes
/* */comments — lines likeint x = 1; /* comment */were counted as Comment instead of Pure"""docstring""" x = 1was counted as Docstringif let Ok(json)dropped failuresCode Quality
std::process::exit()withResult<ExitCode>patternaggregate_stats()to eliminate duplicate aggregation logic#[must_use],const fn, wildcard imports, cast safety, let-else patternsValidation
cargo clippy— zero warningscargo fmt— clean