Fix Windows updater path assertion - #73
Merged
Merged
Conversation
This was referenced Aug 14, 2026
JDS300
added a commit
to JDS300/spinips
that referenced
this pull request
Aug 14, 2026
Takes itsspin/spinips f04c861. Their test-spinui-updater.cjs compared deriveEverQuestRoot()'s canonical long path against a fixture root built from os.tmpdir(), which a Windows runner may expose through an 8.3 alias, so the assertion read runneradmin against RUNNER~1 and failed. Their fix realpaths the expected root. This lands on the same branch as PR itsspin#72 rather than in its own pull request because itsspin#72 is what introduces that test: the Windows job cannot go green on itsspin#72 alone. Both stay separate merge commits, so either can still be reverted on its own with git revert -m 1. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
JDS300
added a commit
to JDS300/spinips
that referenced
this pull request
Aug 14, 2026
Sync upstream PRs itsspin#72 and itsspin#73: progression journal, secure updates, updater path fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.