Skip to content

Fix Windows updater path assertion #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
itsspin merged 1 commit into from
Aug 14, 2026
Merged

Fix Windows updater path assertion #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions loremaster-desktop/scripts/test-spinui-updater.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const assert = require("node:assert/strict");
const { createHash } = require("node:crypto");
const { existsSync, readFileSync } = require("node:fs");
const { mkdir, mkdtemp, readFile, rm, writeFile } = require("node:fs/promises");
const { mkdir, mkdtemp, readFile, realpath, rm, writeFile } = require("node:fs/promises");
const os = require("node:os");
const path = require("node:path");

Expand Down Expand Up @@ -153,8 +153,11 @@ async function main() {
await mkdir(path.dirname(logFile), { recursive: true });
await writeFile(path.join(eqRoot, "eqgame.exe"), "MZfixture");
await writeFile(logFile, "log fixture");
assert.equal(await deriveEverQuestRoot(logFile), eqRoot);
assert.equal(await deriveEverQuestRoot(path.join(uiFiles, "spinui_reloaded")), eqRoot);
// Windows runners may expose os.tmpdir() through an 8.3 alias (RUNNER~1),
// while deriveEverQuestRoot intentionally returns the canonical long path.
const canonicalEqRoot = await realpath(eqRoot);
assert.equal(await deriveEverQuestRoot(logFile), canonicalEqRoot);
assert.equal(await deriveEverQuestRoot(path.join(uiFiles, "spinui_reloaded")), canonicalEqRoot);

const fixture = makeFixtureRelease();
const oldReloaded = path.join(uiFiles, "spinui_reloaded");
Expand Down