fix: prevent hanging when script is piped through curl

[ivangrynenko]

Summary

This PR completes the fix for the curl piping issue by preventing PHP from hanging after the script completes.

Problem

Even after PR #11 was merged, the installer would still hang when piped through curl. The script would execute successfully (showing "Installation completed successfully!") but wouldn't exit cleanly, requiring users to press Ctrl+C.

Root Cause

When piped through curl, PHP's STDIN remains open after the script finishes, causing PHP to wait for more input indefinitely.

Solution

Added cleanup code before exit:

1. Flush all output buffers to ensure messages are displayed
2. Close STDIN explicitly with fclose(STDIN) to signal PHP that no more input is expected
3. This allows the script to exit cleanly without hanging

Test Results

✅ curl -s URL | php - Shows warning and installs core rules, exits cleanly
✅ curl -s URL | php -- --ws - Installs web stack rules, exits cleanly
✅ curl -s URL | php -- --help - Shows help and exits cleanly
✅ Direct execution still works: php install.php

Why Tests Didn't Catch This

The existing test suite only tests direct PHP execution (php install.php ...) and never tests the piped scenario (cat install.php | php). This is a gap in test coverage that should be addressed in a future PR.

Files Changed

• install.php: Added STDIN cleanup before exit (lines 1136-1145)

[gemini-code-assist]

Summary of Changes

Hello @ivangrynenko, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where the PHP installer script would hang indefinitely when executed by piping its content through curl. The core problem was identified as PHP's standard input (STDIN) stream remaining open after the script's execution, causing the process to wait for further input. The solution involves adding cleanup code to install.php that ensures all output buffers are flushed and, crucially, that the STDIN stream is explicitly closed before the script exits. This allows the script to terminate cleanly, improving the user experience for installations via curl.

Highlights

• PHP Script Exit Behavior: Implemented a fix in install.php to prevent the script from hanging when piped through curl by explicitly flushing output buffers and closing STDIN before exiting.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively addresses the hanging issue when the installer script is piped through curl. The solution of flushing output buffers and explicitly closing STDIN is correct. I've added a couple of suggestions for improvement: one to make the output flushing more robust for nested buffers, and another regarding an auto-generated file that seems to have been unintentionally included in the changes. Overall, this is a good fix.

[gemini-code-assist]

This file appears to be an auto-generated installation report created by the install.php script. Its content has completely changed from a changelog to a report, which seems like an artifact from testing the installer. Including auto-generated files that change on each run can add noise to the repository's history.

Could you please confirm if this change is intentional? If not, it might be best to revert the changes to this file to keep the pull request focused on the bug fix.

[gemini-code-assist]

Your current implementation for flushing output buffers only handles the topmost buffer. If there are nested output buffers (which can sometimes be started by PHP extensions or framework components), this might not flush all pending output before the script exits. A more robust approach is to use a while loop with ob_end_flush() to ensure all buffer levels are flushed and closed.

  while (ob_get_level() > 0) {
    ob_end_flush();
  }
  flush();