Skip to content

fix: prevent hanging when script is piped through curl #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ivangrynenko merged 6 commits into from
Aug 20, 2025
Merged

fix: prevent hanging when script is piped through curl #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
21e7f0b
fix: prevent hanging when script is piped through curl
ivangrynenko Aug 20, 2025
f6f5170
docs: add AGENTS.md creation date to UPDATE.md
ivangrynenko Aug 20, 2025
8182088
docs: add AGENTS.md documentation section to UPDATE.md
ivangrynenko Aug 20, 2025
9accd3e
revert: restore .cursor/UPDATE.md to original state
ivangrynenko Aug 20, 2025
45e23c0
fix: restore UPDATE.md from main branch
ivangrynenko Aug 20, 2025
f97a4ec
docs: add version 1.0.6 to UPDATE.md
ivangrynenko Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .cursor/UPDATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,32 @@
# Cursor Rules Updates

## Version 1.0.6 - 2025-08-20

### AGENTS.md Documentation Added

**New Documentation:**
- Added comprehensive AGENTS.md guide for using Cursor Rules with Cursor AI
- Links to all rule bundles (Core, Web Stack, Python, JavaScript Security)
- Tag-based selection documentation and examples
- Installation options reference guide

**Installer Improvements:**
- Fixed hanging issue when piping installer through curl
- Added proper STDIN handling for piped execution
- Improved argument parsing for curl-based installation
- Added fclose(STDIN) to prevent PHP from waiting for input after completion

**Bug Fixes:**
- Resolved script hanging when using `curl ... | php` commands
- Fixed argument parsing when using `--` separator with piped input
- Corrected PHP_SELF detection for piped execution

**File:** `install.php`, `AGENTS.md`
**Impact:** Major improvement to installation experience and documentation
**Breaking Changes:** None - backward compatible

---

## Version 1.0.5 - 2025-01-03

### Major Updates to Pull Request Review Instructions
Expand Down
11 changes: 11 additions & 0 deletions install.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1132,6 +1132,17 @@ function show_help(): void {

echo "\nInstallation " . ($success ? "completed successfully!" : "failed.") . "\n";
echo "Cursor AI will now use these rules when working with your codebase.\n";

// Ensure all output is flushed before exit
if (ob_get_level() > 0) {
ob_flush();
}
flush();
Comment on lines +1137 to +1140
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Your current implementation for flushing output buffers only handles the topmost buffer. If there are nested output buffers (which can sometimes be started by PHP extensions or framework components), this might not flush all pending output before the script exits. A more robust approach is to use a while loop with ob_end_flush() to ensure all buffer levels are flushed and closed.

  while (ob_get_level() > 0) {
    ob_end_flush();
  }
  flush();


// Close stdin if it's open to prevent hanging
if (defined('STDIN') && is_resource(STDIN)) {
fclose(STDIN);
}

exit($success ? 0 : 1);
}
Expand Down