Skip to content

Fix spdlog error with sed in GitHub actions - #6

Closed
izzy2lost wants to merge 2 commits into
android-devfrom
cursor/fix-spdlog-error-with-sed-in-github-actions-b8f5
Closed

Fix spdlog error with sed in GitHub actions#6
izzy2lost wants to merge 2 commits into
android-devfrom
cursor/fix-spdlog-error-with-sed-in-github-actions-b8f5

Conversation

@izzy2lost

Copy link
Copy Markdown
Owner

Add sed commands to GitHub Actions workflows to resolve spdlog compilation errors in torch/CMakeLists.txt.

The torch/CMakeLists.txt was failing to find spdlog as a required package, leading to build failures. This PR modifies the build process to first attempt a quiet find_package for spdlog, and if not found, it fetches spdlog via FetchContent. It also adds conditional linking to correctly handle spdlog::spdlog or spdlog targets, improving build robustness.


Open in Cursor Open in Web

cursoragent and others added 2 commits August 7, 2025 02:12
Co-authored-by: izzynochill <izzynochill@gmail.com>
Co-authored-by: izzynochill <izzynochill@gmail.com>
@cursor

cursor Bot commented Aug 7, 2025

Copy link
Copy Markdown

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@izzy2lost izzy2lost closed this Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants