Skip to content

Fix spdlog error with sed in GitHub actions #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
izzy2lost wants to merge 2 commits into from
Closed

Fix spdlog error with sed in GitHub actions #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2db67a
Checkpoint before follow-up message
cursoragent Aug 7, 2025
7901f19
Fix spdlog find_package and linking issues in torch CMakeLists.txt
cursoragent Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/linux-compile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@ jobs:
run: sudo apt update
- name: Install dependencies
run: sudo apt-get install gcc g++ git cmake ninja-build lsb-release libsdl2-dev libpng-dev libsdl2-net-dev libzip-dev zipcmp zipmerge ziptool nlohmann-json3-dev libtinyxml2-dev libspdlog-dev libboost-dev libopengl-dev libogg-dev libvorbis-dev
- name: Fix spdlog issue in torch
run: |
# Fix spdlog find_package issue in torch CMakeLists.txt
sed -i 's/find_package(spdlog REQUIRED)/find_package(spdlog QUIET)\n\tif(NOT spdlog_FOUND)\n\t\tFetchContent_Declare(\n\t\t\tspdlog\n\t\t\tGIT_REPOSITORY https:\/\/github.com\/gabime\/spdlog.git\n\t\t\tGIT_TAG 7e635fca68d014934b4af8a1cf874f63989352b7\n\t\t)\n\t\tFetchContent_MakeAvailable(spdlog)\n\t\tset(spdlog_FOUND TRUE)\n\tendif()/' torch/CMakeLists.txt
sed -i 's/target_link_libraries(${PROJECT_NAME} PUBLIC spdlog::spdlog)/if(spdlog_FOUND)\n\tif(TARGET spdlog::spdlog)\n\t\ttarget_link_libraries(${PROJECT_NAME} PUBLIC spdlog::spdlog)\n\telse()\n\t\ttarget_link_libraries(${PROJECT_NAME} PUBLIC spdlog)\n\tendif()\nendif()/' torch/CMakeLists.txt
- name: Install latest SDL
run: |
export PATH="/usr/lib/ccache:/usr/local/opt/ccache/libexec:$PATH"
Expand Down
16 changes: 14 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,13 @@ jobs:
- name: Update machine
run: sudo apt update
- name: Install dependencies
run: sudo apt-get install gcc g++ git cmake ninja-build lsb-release libsdl2-dev libsdl2-net-dev libpng-dev libsdl2-net-dev libzip-dev zipcmp zipmerge ziptool nlohmann-json3-dev libtinyxml2-dev libspdlog-dev libboost-dev libopengl-dev libogg-dev libvorbis-dev
run: |
sudo apt-get install gcc g++ git cmake ninja-build lsb-release libsdl2-dev libsdl2-net-dev libpng-dev libsdl2-net-dev libzip-dev zipcmp zipmerge ziptool nlohmann-json3-dev libtinyxml2-dev libspdlog-dev libboost-dev libopengl-dev libogg-dev libvorbis-dev
- name: Fix spdlog issue in torch
run: |
# Fix spdlog find_package issue in torch CMakeLists.txt
sed -i 's/find_package(spdlog REQUIRED)/find_package(spdlog QUIET)\n\tif(NOT spdlog_FOUND)\n\t\tFetchContent_Declare(\n\t\t\tspdlog\n\t\t\tGIT_REPOSITORY https:\/\/github.com\/gabime\/spdlog.git\n\t\t\tGIT_TAG 7e635fca68d014934b4af8a1cf874f63989352b7\n\t\t)\n\t\tFetchContent_MakeAvailable(spdlog)\n\t\tset(spdlog_FOUND TRUE)\n\tendif()/' torch/CMakeLists.txt
sed -i 's/target_link_libraries(${PROJECT_NAME} PUBLIC spdlog::spdlog)/if(spdlog_FOUND)\n\tif(TARGET spdlog::spdlog)\n\t\ttarget_link_libraries(${PROJECT_NAME} PUBLIC spdlog::spdlog)\n\telse()\n\t\ttarget_link_libraries(${PROJECT_NAME} PUBLIC spdlog)\n\tendif()\nendif()/' torch/CMakeLists.txt
- name: ccache
uses: hendrikmuhs/ccache-action@v1.2.14
with:
Expand Down Expand Up @@ -222,7 +228,13 @@ jobs:
- name: Update machine
run: sudo apt update
- name: Install dependencies
run: sudo apt-get install gcc g++ git cmake ninja-build lsb-release libsdl2-dev libsdl2-net-dev libpng-dev libsdl2-net-dev libzip-dev zipcmp zipmerge ziptool nlohmann-json3-dev libtinyxml2-dev libspdlog-dev libboost-dev libopengl-dev libogg-dev libvorbis-dev
run: |
sudo apt-get install gcc g++ git cmake ninja-build lsb-release libsdl2-dev libsdl2-net-dev libpng-dev libsdl2-net-dev libzip-dev zipcmp zipmerge ziptool nlohmann-json3-dev libtinyxml2-dev libboost-dev libopengl-dev libogg-dev libvorbis-dev
- name: Fix spdlog issue in torch
run: |
# Fix spdlog find_package issue in torch CMakeLists.txt
sed -i 's/find_package(spdlog REQUIRED)/find_package(spdlog QUIET)\n\tif(NOT spdlog_FOUND)\n\t\tFetchContent_Declare(\n\t\t\tspdlog\n\t\t\tGIT_REPOSITORY https:\/\/github.com\/gabime\/spdlog.git\n\t\t\tGIT_TAG 7e635fca68d014934b4af8a1cf874f63989352b7\n\t\t)\n\t\tFetchContent_MakeAvailable(spdlog)\n\t\tset(spdlog_FOUND TRUE)\n\tendif()/' torch/CMakeLists.txt
sed -i 's/target_link_libraries(${PROJECT_NAME} PUBLIC spdlog::spdlog)/if(spdlog_FOUND)\n\tif(TARGET spdlog::spdlog)\n\t\ttarget_link_libraries(${PROJECT_NAME} PUBLIC spdlog::spdlog)\n\telse()\n\t\ttarget_link_libraries(${PROJECT_NAME} PUBLIC spdlog)\n\tendif()\nendif()/' torch/CMakeLists.txt
- name: ccache
uses: hendrikmuhs/ccache-action@v1.2.14
with:
Expand Down
Loading