Skip to content

fix: clarify ladder progress status #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackhai9 merged 2 commits into from
Aug 28, 2026
Merged

fix: clarify ladder progress status #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
164d18f
fix: preserve ladder progress in status messages
jackhai9 Aug 28, 2026
2516df1
test: verify explicit ladder result statuses
jackhai9 Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions e2e/binance-orderbook/specs/control-flows.pw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,8 @@ test('starting a ladder preserves action slots and turns only the active action
const submissionsBeforeStop = (await readFixtureState(page)).events
.filter((event) => event.type === 'order-submitted').length;
await stop.click();
await expect(panel.locator('#jh-binance-ladder-status')).toContainText('已停止');
const status = panel.locator('#jh-binance-ladder-status');
await expect(status).toContainText('阶梯开多已停止');
await expect(startLong).toBeEnabled();
await expect(startShort).toBeEnabled();
await expect(stop).toHaveCount(0);
Expand All @@ -188,6 +189,9 @@ test('starting a ladder preserves action slots and turns only the active action
const state = await readFixtureState(page);
const submissionsAfterStop = state.events
.filter((event) => event.type === 'order-submitted').length;
await expect(status).toHaveText(
`阶梯开多已停止 · 已挂 ${submissionsAfterStop} 笔 · 已撤 0 笔`,
);
expect(submissionsAfterStop).toBeLessThanOrEqual(submissionsBeforeStop + 1);
await page.waitForTimeout(700);
expect((await readFixtureState(page)).events
Expand Down Expand Up @@ -248,7 +252,7 @@ test('a complete ladder submits the planned five native orders and restores cont
const stop = panel.getByRole('button', { name: '停止开多' });

await startLong.click();
await expect(panel.locator('#jh-binance-ladder-status')).toContainText('完成 5/5', {
await expect(panel.locator('#jh-binance-ladder-status')).toHaveText('阶梯开多已完成 · 已挂 5/5 笔', {
timeout: 12_000,
});
await expect(startLong).toBeEnabled();
Expand Down
Loading
Loading