Repository navigation
feat(inventory): dual-stack IPv6 Import-Inventory (#58) - #68
Merged
Merged
Conversation
Import-Inventory now normalizes IPv4 and IPv6 device ips and subnet CIDRs via family-agnostic helpers instead of the IPv4-only converters. Node identity remains one address per row; prefer IPv4 when a dual-stack host needs a single identity. Co-authored-by: Jacobrakai <jacobyoby@users.noreply.github.com>
jacobyoby
marked this pull request as ready for review
September 9, 2026 19:22
This was referenced Sep 9, 2026
jacobyoby
added a commit
that referenced
this pull request
Sep 9, 2026
Replace the hand-built Import-Topology IPv6 path with inventory JSON (v4 + v6 node/subnet) through Import-Inventory → Export-DrawIO so the packaged smoke gate exercises #68. Assert both family IPs in XML. Closes #75. Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Jacobrakai <jacobyoby@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #58.
Import-Inventorystill calledConvertTo-NormalizedIPv4Address/ConvertTo-NormalizedIPv4Cidrafter #57, so ARP and DrawIO could handle IPv6 while the documented inventory path rejected it.Changes
ConvertTo-NormalizedIPAddressandConvertTo-NormalizedCidr(canonical string form; CIDR host bits cleared for both families).Import-Inventoryuses those helpers. IPv4-named converters stay in place forInvoke-NetworkDiscovery(Wizard + Invoke-NetworkDiscovery: IPv6 / dual-stack scan follow-on #61 follow-on).ipper device. Uniqueness is the normalized address string (compressed vs expanded IPv6 are duplicates). When a dual-stack host needs only one row, prefer IPv4.Tests
Import-Inventoryof a dual-stack fixtureDoes not merge. Wizard / discovery IPv6 scanning remains out of scope.