Repository navigation
fix(netbox): IPv6 → primary_ip6; don’t map unknown reachability to offline - #77
Merged
Merged
Conversation
Export-NetBox put every node IP in primary_ip4 and treated Reachable=$null as offline. Place IPv6 in primary_ip6 (v6-only leaves primary_ip4 empty), leave status empty when reachability is unknown, and cover v4/v6/dual-stack plus the null-reachable regression in Pester. Closes #72. Co-authored-by: Jacobrakai <jacobyoby@users.noreply.github.com>
jacobyoby
marked this pull request as ready for review
September 9, 2026 20:05
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #72.
Problem
Export-NetBoxstill stuffed every node IP intoprimary_ip4(leavingprimary_ip6unused) and mappedReachable=$nulltooffline— the same honesty bug the wizard already fixed for DrawIO.Change
primary_ip4; IPv6 identity →primary_ip6(the other column empty).Reachable=$true→active,$false→offline,$null→ emptystatus(NetBox has no unknown; do not invent a status).$nullReachable must not becomeoffline.[Unreleased]updated.Out of scope
Gallery release, SnmpWalk IPv6, cred-map IPv6, CI smoke, MCP, LLDP.
Verification
./tests/run-tests.sh(pwsh/Pester). Touched tests areExport-NetBox (#38)andExport-NetBox (#72).