Repository navigation
fix(snmp): accept IPv6 TargetIP on Invoke-SnmpWalk - #78
Merged
Merged
Conversation
ValidateScript was IPv4/FQDN-only, so dual-stack SNMP targets failed before the walk. Parse IPv4/IPv6 with IPAddress.TryParse; keep FQDN acceptance and a clear error on garbage input. Closes #73. Co-authored-by: Jacobrakai <jacobyoby@users.noreply.github.com>
jacobyoby
marked this pull request as ready for review
September 9, 2026 20:16
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #73.
Problem
Invoke-SnmpWalkTargetIPValidateScript was IPv4/FQDN-only, so dual-stack SNMP targets failed before the walk — blocking post-#56/#57 IPv6 neighbors.Change
[System.Net.IPAddress]::TryParse(same parse path as inventory helpers).[Unreleased]bullet.Out of scope
Credential-map IPv6 CIDR keys, CI smoke, Gallery release, MCP, live SNMP integration tests.
Verification
./tests/run-tests.sh(pwsh/Pester only). 157 tests passed, 0 failed. Touched tests areInvoke-SnmpWalk parameter validation.