clr: fix segment-scheduled graph handoffs (single kernel/hostnode) — coverage experiment (clone of ROCm#8055)#3
Open
jainprad wants to merge 4 commits into
Open
Conversation
Add this PR's own coverage gate (build_and_test.sh, collect_and_gate.sh, pr-diff-coverage.yml) so the segsched-handoff clone is measured on its own changed lines independently of other PRs. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clone of upstream ROCm/rocm-systems#8055 (by @LeoZhao-BJ) for a code-coverage experiment. Upstream PR is left untouched — this copies its 3 commits (
git cherry-pick -x) onto this fork'sdevelop.Fixes HIP graph segment-scheduling visibility: applies system-scope release when a captured AQL batch hands off to an uncaptured host node, and for single-packet AQL batches applies the release fence to
firstHeader.Runtime changes
projects/clr/hipamd/src/hip_graph_internal.hppprojects/clr/rocclr/device/rocm/rocvirtual.cppTests (existing + new)
hipLaunchHostFuncWithGraph.cc— addsUnit_hipLaunchHostFunc_SameStreamCapturedDtoH_UncapturedHosthipGraphInstantiateWithFlags.cc,graph.yamlTest plan
--coverage+ PR code on a ROCm-compatible base.Made with Cursor