Skip to content

fix(settings): show text in editable ComboBoxes #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
obesity40 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(settings): show text in editable ComboBoxes #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/OddSnap/UI/SettingsWindow.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,20 @@
Margin="0,0,6,0"
RecognizesAccessKey="True"
VerticalAlignment="{TemplateBinding VerticalContentAlignment}"/>
<!-- Editable mode needs a real TextBox here. Without
it, IsEditable=True ComboBoxes render no text at
all (the ContentPresenter is hidden by WPF when
IsEditable is set, and there is nothing to take
its place). -->
<TextBox x:Name="PART_EditableTextBox"
Margin="0,0,6,0"
Padding="0"
Background="Transparent"
Foreground="{TemplateBinding Foreground}"
CaretBrush="{TemplateBinding Foreground}"
VerticalContentAlignment="{TemplateBinding VerticalContentAlignment}"
Visibility="Collapsed"
Focusable="True"/>
<Path Grid.Column="1"
Width="8"
Height="4"
Expand Down Expand Up @@ -275,6 +289,10 @@
<Trigger Property="IsEnabled" Value="False">
<Setter TargetName="Bd" Property="Opacity" Value="0.45"/>
</Trigger>
<Trigger Property="IsEditable" Value="True">
<Setter TargetName="ContentSite" Property="Visibility" Value="Collapsed"/>
<Setter TargetName="PART_EditableTextBox" Property="Visibility" Value="Visible"/>
</Trigger>
</ControlTemplate.Triggers>
</ControlTemplate>
</Setter.Value>
Expand Down