Skip to content

Harden release workflow against script injection via release_version #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndreasIgel merged 1 commit into from
Jul 15, 2026
Merged

Harden release workflow against script injection via release_version #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions .github/workflows/maven-central-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,21 @@ jobs:

- name: Determine version
id: version
env:
RELEASE_VERSION: ${{ github.event.inputs.release_version }}
run: |
VERSION="${{ github.event.inputs.release_version }}"
echo "VERSION=$VERSION" >> $GITHUB_OUTPUT
# Do NOT interpolate the workflow input directly into the shell;
# read the untrusted input from an environment variable instead to
# avoid script injection.
VERSION="$RELEASE_VERSION"

# Validate against a strict semver pattern before using it anywhere.
if ! [[ "$VERSION" =~ ^[0-9]+\.[0-9]+\.[0-9]+(-[0-9A-Za-z.-]+)?(\+[0-9A-Za-z.-]+)?$ ]]; then
echo "::error::Invalid release version '$VERSION'. Expected semver, e.g. 0.2.0 or 0.2.0-beta.1"
exit 1
fi

echo "VERSION=$VERSION" >> "$GITHUB_OUTPUT"
echo "Releasing version: $VERSION"

- name: Update POM versions
Expand Down
Loading