Skip to content
This repository was archived by the owner on Mar 9, 2023. It is now read-only.

Ms create input spinner - #9

Open
Madeuss wants to merge 14 commits into
mainfrom
ms-create-input-spinner
Open

Ms create input spinner#9
Madeuss wants to merge 14 commits into
mainfrom
ms-create-input-spinner

Conversation

@Madeuss

@Madeuss Madeuss commented Nov 22, 2022

Copy link
Copy Markdown
Member

O que esse PR faz?

  • Cria o componente de number input spinner baseado no chakra-ui
  • Refatora o arquivo de export dos componentes para o seguinte padrão export * from path ao invés de criar um export para cada coisa
  • Adiciona um template de PR's

Screenshots

number_input_spinner

Antes de pedir os seus joinhas, confira:

  • Changelog?
  • Base branch está correta? (Por padrão é a main)

@Madeuss
Madeuss requested a review from fczuardi November 22, 2022 14:22
Comment thread components/InputSpinner/index.tsx Outdated
Comment thread package.json
"lint": "next lint"
},
"dependencies": {
"@chakra-ui/icons": "^2.0.12",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acho que você não precisa adicionar @chakra-ui/icons , senão me engano ele esta dentro do @chakra-ui/react

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

achei que estaria também, mas não estava lá na node_modules e ele ficou pedindo pra adicionar

Comment thread lib/index.ts
Comment thread .github/pull_request_template.md Outdated
Comment thread components/InputSpinner/index.tsx Outdated
Comment thread components/InputSpinner/index.tsx Outdated
@Madeuss
Madeuss requested review from Gu7z, fczuardi and felipeduardo and removed request for Gu7z and felipeduardo November 23, 2022 19:07
@Madeuss
Madeuss requested review from Gu7z and felipeduardo and removed request for felipeduardo November 23, 2022 19:08
Comment thread components/InputSpinner/index.tsx Outdated
Comment thread components/InputSpinner/index.tsx Outdated
t: Function,
Headline: HeadlineComponent,
Link: LinkComponent,
newContractPath: string

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

foi seu editor que removeu as leading commas? se formos começar a ter estes ruídos de code formatting, acho que já seria bom colocar um .prettierrc no projeto com um conjunto qqer de preferencias só para nao dar diff entre colaboradores com editores e code formatters diferentes, padronizar estas regrinhas (ser com ou sem por mim tanto faz)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

acho bom fazer, mas que seria melhor criar essa config de prettier/eslint em um novo PR pra nao fugir muito da ideia desse aqui e nem atrasar

Comment thread components/Welcome/index.tsx
Madeuss and others added 2 commits November 24, 2022 09:34
Co-authored-by: Fabricio C Zuardi <fabricio@fabricio.org>
Co-authored-by: Fabricio C Zuardi <fabricio@fabricio.org>
@Madeuss
Madeuss requested review from fczuardi and removed request for Gu7z November 24, 2022 12:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants