This repository was archived by the owner on Mar 9, 2023. It is now read-only.
Ms create input spinner #9
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # O que esse PR faz? | ||
|
|
||
| ## Qual o problema encontrado? | ||
|
|
||
| - descrição do problema | ||
| - **screenshots** se possível | ||
| - exemplo de `código` se necessário | ||
| - mensagem de erro (log, excessão, alert) | ||
|
|
||
| ## Qual a solução aplicada? | ||
|
|
||
| - descrição da solução | ||
| - **screenshots** se possível | ||
| - exemplo de `código` se necessário | ||
|
|
||
| ## Screenshots |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| import { | ||
| HStack, | ||
| Input, | ||
| InputGroup, | ||
| InputLeftElement, | ||
| InputRightElement, | ||
| NumberInputProps, | ||
| useNumberInput, | ||
| } from '@chakra-ui/react' | ||
| import { AddIcon, MinusIcon } from '@chakra-ui/icons' | ||
|
|
||
| interface Props { | ||
| minusIcon?: React.ReactNode | ||
| addIcon?: React.ReactNode | ||
| } | ||
|
|
||
| export function InputSpinner(props: Props & NumberInputProps) { | ||
| const { step, defaultValue, min, width, minusIcon, addIcon } = props | ||
|
|
||
| const { getInputProps, getIncrementButtonProps, getDecrementButtonProps } = | ||
| useNumberInput({ | ||
| step: step || 1, | ||
| defaultValue: defaultValue || 0, | ||
| min: min || 0, | ||
| ...props, | ||
| }) | ||
|
|
||
| const inc = getIncrementButtonProps() | ||
| const dec = getDecrementButtonProps() | ||
| const input = getInputProps() | ||
|
|
||
| return ( | ||
| <HStack maxW={width || '224px'}> | ||
| <InputGroup> | ||
| <InputLeftElement ml={3} mt={1} {...dec}> | ||
| {minusIcon || <MinusIcon fontSize="small" />} | ||
| </InputLeftElement> | ||
| <Input textAlign="center" height={12} {...input} /> | ||
| <InputRightElement mr={3} mt={1} {...inc}> | ||
| {addIcon ? addIcon : <AddIcon fontSize="small" />} | ||
| </InputRightElement> | ||
| </InputGroup> | ||
| </HStack> | ||
| ) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,3 @@ | ||
| export * from '../components/Welcome' | ||
| export * from '../components/NextButton' | ||
| export * from '../components/InputSpinner' | ||
|
Madeuss marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
foi seu editor que removeu as leading commas? se formos começar a ter estes ruídos de code formatting, acho que já seria bom colocar um .prettierrc no projeto com um conjunto qqer de preferencias só para nao dar diff entre colaboradores com editores e code formatters diferentes, padronizar estas regrinhas (ser com ou sem por mim tanto faz)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
acho bom fazer, mas que seria melhor criar essa config de prettier/eslint em um novo PR pra nao fugir muito da ideia desse aqui e nem atrasar