Repository navigation
fix(chores): any-day follow-ups from the #364 review - #369
Merged
Merged
Conversation
- A card from someone's own schedule keeps its person overnight, clams or not. - Moved off any-day, or deleted, its open card goes instead of lingering as a one-time chore due every day (holding back the bonus, logging misses). - A repeating schedule made one-time counts only completions logged after the change (one_time_after_history_id, migration 40), so it isn't cleared undone. - Copy keeps an any-day group's period. - Two-week periods count from the household's date the schedule was made. - The week calendar handles a week that holds two periods, and plans nothing for a period already done. - The wizard takes whole numbers only. - Due-time sounds skip a one-time chore due on a later day. - A card made on its period's last day doesn't count that day. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
adamecker
pushed a commit
to adamecker/HomeGlow
that referenced
this pull request
Nov 1, 2026
…, jherforth#370; admin jherforth#366; ha-panels jherforth#371) into test/all-combined # Conflicts: # server/migrations/registry.js # server/tests/anyDayChores.test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the any-day issues mrramam found after #364 merged (comment). Each fix is numbered as in that comment.
Fixes
one_time_after_history_id, migrationschema40-oneTimeAfter). The prune counts only completions logged after it. Before, a completion from when it repeated (now often moved onto it from a card) counted, so the chore was cleared undone that night and its chore deleted with it. This also fixes plain day-of schedules made one-time.The two that weren't run end to end
Checks
3m, with no page errors.check:i18nand the build pass.🤖 Generated with Claude Code