Skip to content

fix(evolution): align repository overview and refresh state - #15

Merged
jhinpan merged 3 commits into
mainfrom
fix/repository-overview-final
Jul 24, 2026
Merged

fix(evolution): align repository overview and refresh state#15
jhinpan merged 3 commits into
mainfrom
fix/repository-overview-final

Conversation

@jhinpan

@jhinpan jhinpan commented Jul 24, 2026

Copy link
Copy Markdown
Owner

Summary

  • align README, skill guidance, citation, and repository metadata with the active gfx942/gfx950 scope and maintainer-controlled workflow
  • distinguish complete baseline harvests from rolling per-source discovery and preserve conservative watermarks after successful empty scans
  • allowlist the canonical AMDGPU guide path so future updates are discovered, with regression coverage and refreshed manifest provenance
  • document actual file/line budgets, Draft creation behavior, CI triggers, administrator bypasses, and freshness ownership

Test plan

  • python3 -m pytest tests (57 passed)
  • python3 scripts/validate.py (0 errors)
  • retrieval and answer evaluations
  • artifact provenance and corpus manifest checks

Merge contract

  • Every branch commit is authored and committed by Jin Pan <jin.pan@amd.com> with no co-author trailers.
  • Use rebase merge so the exact author identity is preserved on main.

Update repository-facing documentation to match the active CDNA scope and maintainer-controlled workflow. Track the canonical guide path and preserve safe initial watermarks for empty source scans.
@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@sourcery-ai

sourcery-ai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Reviewer's Guide

Aligns documentation, evolution tooling, and source registry with the active CDNA scope and maintainer-controlled workflow, tightens CI/quality contracts, and updates discovery state handling for empty initial scans and allowlisted AMDGPU guide paths.

Sequence diagram for empty initial discovery refresh updating evolution state

sequenceDiagram
  participant discover_py as discover_py
  participant source_repo as source_repository
  participant evolution_state_yaml as evolution_state_yaml

  discover_py->>source_repo: run_discovery(source_id, since)
  source_repo-->>discover_py: [no_changes_found]
  alt watermark_exists
    discover_py->>evolution_state_yaml: update sources[source_id] with newest merge and pr
  else watermark_is_none_and_since
    discover_py->>evolution_state_yaml: set sources[source_id] = { merged_at: since, pr: 0, merge_sha: '', captured_at: capture_date }
  end
Loading

File-Level Changes

Change Details Files
Clarify corpus freshness, evolution workflow, and maintainer-controlled boundaries in top-level docs and skill metadata.
  • Reworked README and SKILL.md corpus freshness sections to distinguish baseline harvest cutoffs, per-source incremental discovery, and manifest inventory.
  • Documented that automation creates a single rolling Draft evolution PR from a disposable clone, with maintainers responsible for acceptance and merges.
  • Expanded maintenance tooling description to mention sources.yaml as the canonical registry, file/line budgets, MI355 evaluation behavior, and CI trigger conditions including admin bypasses.
  • Updated citation title to match the AMD CDNA-only scope and refreshed wording around self-evolution and untrusted upstream data.
README.md
SKILL.md
ops/evolution/README.md
VERIFICATION.md
CITATION.bib
Adjust evolution discovery behavior to persist conservative watermarks on empty initial scans and align sources/manifest state.
  • Modified run_discovery to write a durable evolution-state watermark when the first successful scan finds no changes but has a caller-provided since bound.
  • Extended evolution-state.yaml with initial safe-since entries for rocm-triton and rocm-flash-attention.
  • Updated corpus-manifest.yaml source_registry_sha256 to match the new sources registry contents.
scripts/evolve/discover.py
data/evolution-state.yaml
data/corpus-manifest.yaml
Allowlist the canonical AMDGPU optimization guide path in the sources registry and add regression coverage for path-based decisions.
  • Added docs/amdgpu_kernel_optimization_guide.md to the include_paths for the amdgpu-optimization-guide source in sources.yaml.
  • Introduced a test ensuring that changes to the canonical AMDGPU guide path produce a deferred candidate decision with an allowlisted-path relevance reason.
data/sources.yaml
tests/test_evolution.py
Tighten evolution tooling semantics and PR review contracts.
  • Updated the evolve package docstring to emphasize maintainer-controlled evolution tooling.
  • Relaxed draft_pr.py wording so the rolling PR is described as created as Draft and explicitly assigns acceptance and merge decisions to maintainers, while treating generated checks as preconditions for maintainer acceptance.
  • Clarified daily evolution service README to state it never pushes to main or performs approvals/merges, and that maintainers own those decisions.
scripts/evolve/__init__.py
scripts/evolve/draft_pr.py
ops/evolution/README.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

jhinpan added 2 commits July 24, 2026 04:46
Keep the generated manifest as a projection while canonical rolling and per-page freshness remain with their owning files.
Describe the service's actual create-or-edit behavior without implying that an existing PR must remain Draft.
@jhinpan
jhinpan merged commit 9252153 into main Jul 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant