Randomize the 'congrats' message#16
Open
tgbates wants to merge 2 commits into
Open
Conversation
…ngrats message when points are awarded, updated Process Points business rule to use the new script include.
Token for bot, new Script Include RandomMessage to return a random Co…
Closed
jnerius
changed the title
Owner
|
This closes #4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a script include 'RandomMessage' for different random messages.
Pass it the username and the point tally.
Replaced this line in the ProcessPoints Business Rule:
bodyString += '&text=' + gs.urlEncode('Congrats ' + thing + ' you now have ' + grSlackUser.points + ' points');with this:
var randomMessage = new x_snc_slack_points.RandomMessage(); bodyString += '&text=' + gs.urlEncode(randomMessage.getMessage(thing, grSlackUser.points));