Publish HACP v0.3 candidate qualification evidence - #68
Conversation
Reviewer's GuideThis PR publishes a regenerated HACP v0.3 candidate evidence package: it adopts owner-approved Sequence diagram for v0.3 candidate regeneration and validationsequenceDiagram
participant Owner as Joe Feser
participant HACP as HACP package generator
participant WITS as WITS producer
participant Validator as HACP external validator
participant Evidence as Public evidence
Owner->>HACP: approve exact io.hacp.*.v0.3-candidate domains
HACP->>HACP: buildConformancePackage()
HACP-->>WITS: canonical candidate package
WITS->>WITS: generate candidate bundles independently
WITS-->>Validator: three external bundles
Validator->>Validator: validateExternalBundleRoot()
Validator-->>Evidence: publish validation receipt and public-safe bytes
Flow diagram for HACP candidate publication boundariesflowchart TD
Candidate[Publish v0.3 candidate evidence]
Candidate --> Evidence[Bounded local and synthetic evidence]
Candidate --> Interop[Independent WITS production and cross-validation]
Candidate --> Limits[Retained candidate limitations]
Limits --> Task[WITS Task 1.3f remains open]
Limits --> Runtime[No runtime execution authorization]
Limits --> Release[No standard or full-release conformance]
Limits --> Effects[No distributed or external-effects claim]
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="scripts/validate-external-bundle.test.mjs" line_range="238-239" />
<code_context>
- assert.equal(result.producer.sourceCommit, '9fa658f7faf2522de6ea12408c784bb987223f00');
+ assert.equal(result.producer.sourceCommit, '48bac116b1077a81dc7adf8e34c78cc3da17c7b2');
assert.equal(result.conformancePackage.canonicalNegativeCases, 22);
- assert.equal(result.conformancePackage.diagnosticSetsComparedExactly, true);
- assert.deepEqual(result.bundles.map(({ kind, records }) => [kind, records]), [
- ['successful_continuation', 6],
- ['pre_start_stop', 4],
</code_context>
<issue_to_address>
**issue (testing):** The updated external-bundle test no longer asserts that `diagnosticSetsComparedExactly` is true, so a validator that stops comparing the 22 canonical negative diagnostic sets can still pass this test and falsely report regenerated WITS evidence as fully cross-validated.
**Triggers:** When the negative-case comparison regresses while bundle validation and the positive bundle assertions continue to pass.
**Suggested fix:** Restore the assertion that `result.diagnosticSetsComparedExactly` is `true`.
</issue_to_address>Sourcery assessment
Needs a human reviewer. 1 finding to address first, and the change publishes a new candidate digest-domain contract and regenerates all dependent hashes and external fixtures. If the approved strings or regenerated evidence are wrong, consumers can produce or reject incompatible records after the repository is reverted, but the bounded candidate corpus and digests can be regenerated and migrated without an irreversible production effect.
Blocking findings: scripts/validate-external-bundle.test.mjs:239
PR Summary by QodoPublish HACP v0.3 candidate qualification evidence
AI Description
Diagram
High-Level Assessment
Files changed (74)
|
Code Review by Qodo
1.
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5cd7036f5b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
PR review loop disposition:
This note records why the loop is not waiting indefinitely on this finding state. |
|
@codex review agent-control fresh required Codex review request |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
PR review loop disposition:
This note records why the loop is not waiting indefinitely on this finding state. |
1 participant
Summary
io.hacp.*.v0.3-candidatedigest domains and regenerate the canonical packageValidation
npm run hacp:doctor -- schemas/examples --manifest schemas/examples/manifest.json— 15 valid / 9 invalidnpm run hacp:cli-bridge-examples— 8 filesnpm run hacp:v03-candidate— 43/43npm run hacp:v03-external -- --root fixtures/supplementary/v0.3-candidate/wits— 3 bundles / 22 exact negative diagnostic setsgit diff --checkCandidate boundaries
This publishes candidate evidence only. It does not complete WITS Task 1.3f, amend R4B, authorize runtime execution, prove distributed or external effects, or establish full-release conformance. Bidirectional production/consumption remains a later full-release gate.
Summary by Sourcery
Publish the corrected and independently validated HACP v0.3 candidate evidence package while preserving its documented scope and limitations.
New Features:
Bug Fixes:
org.hacp.*to the approvedio.hacp.*values and regenerate affected records, manifests, and validation evidence.Enhancements:
Documentation:
Tests:
Chores: