Repository navigation
fix(enrichment): reject generated titles for superseded content - #205
Merged
Merged
Conversation
johnny4young
marked this pull request as ready for review
October 7, 2026 21:59
- Exclude only kinds without a text body from the guarded title write, so masked and newer kinds keep the generated titles capture planned for them - Use the shared read visibility rule, so an expired pinned, boarded or snippet row stays titleable - Cover both rules and describe the eligibility in the titles notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding
A generated title can complete after its captured body has been edited. The existing empty-title predicate protects manual titles but permits an annotation for the old body to label the new body.
Correction
Dependency and exact source
Stacked on #204, base branch fix/content-bound-embeddings at 919acb3.
Exclusive title diff: seven files, 279 additions, six deletions. The parent embedding fix and its one-comma formatter correction are inherited, not repeated independent findings.
Head: 3635b10
Verified local/remote tree: 563196a31ebb4f6e568141507c8a5a21c112c1c9
The earlier draft tree was refreshed to remove the analogous trailing comma in the title test before publication. No assertion or gate was relaxed. Review/integrate #204 before this child; no merge has been performed.
Regression evidence
Limits and reviewer focus
Review the transaction predicate, optional-capability compatibility and callback/upload semantics. Content-equal ABA is valid if the current row remains eligible and untitled; different replacement text is rejected. This does not retroactively repair existing titles or add a new enrichment scheduler.
No UI layout, schema, dependency, threshold, workflow, license, permission, live clipboard, merge, release or deployment changes. No combined qualification of other open repairs is claimed.