Repository navigation
fix(renderer): print quotes, Save As recipe binding, tour console - #255
Merged
Merged
Conversation
- The print hook serialized each argument with the scratchpad value serializer, which uses repr, so print("sum =", 55) appeared in the console as 'sum =' 55.
- Top-level string arguments are now primitive string payloads holding the printed text; strings nested in containers keep repr, as print itself does.
- Run the real bootstrap under CPython in a new test of both cases.
Changelog: none
- A recipe bound while a language-changing Save As was writing was dropped from the tab by the live-state merge but stayed in the recipe store. - Track whether the merge dropped a live binding and unbind it alongside the existing original-binding case. Changelog: none
- startTour opened the bottom console before awaiting editor readiness, so a start interrupted by another dialog still changed the layout. - Open it in the same branch that activates the first step; the empty-workspace sample tab is still created up front because the tour waits for an editor. Changelog: none
- The website tour spec told the console row from the inline pill by the repr quote that print used to add; printed strings now match print, so scope the assertion to the console row instead. Changelog: none
…ollowups # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three renderer follow-ups from the October review:
printshowed repr quotes.print("sum =", 55)appeared in the console as'sum =' 55: the print hook serialized each argument with the scratchpad value serializer, which usesrepr. Top-level string arguments now become primitive string payloads holding the printed text (no Details chip, same as before), while strings inside containers keeprepr, matchingprint. The capturedtextwas already correct.withLiveTabState, but the recipe store kept it.saveTabnow detects a dropped live binding and unbinds it.startTouropened the bottom console before awaiting editor readiness. It now opens in the branch that activates step one; the console step still callsensureConsoleVisible.Validation
tests/workers/pythonPrintPayloads.test.ts: runs the real bootstrap under CPython; skipped ifpython3is absent.editorSaveInputRetention.test.ts.GuidedTourFocus.test.tsx.tsc --noEmit,typecheck:tests, lint,check:i18n,check:i18n:copy,changelog:checkgreen.build:web+preview:web, Playwright):"sum =", 55and["a"], "b"showssum = 55and['a'] b(the list keeps its Details chip);suma = 55, Spanish tour copy);