Write the cos part of grpmn and bvec for lasym - #30
Open
CharlesCNorton wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grpmnandbveccarry a second symmetry index forlasym,ndim = 2, but the debug output writes only the first slice.analyt.f90says so at the call:! missing dim: (ndim: 1 or 2). The cos half is therefore not reachable from the dumps, and a consumer comparing against them can only check the sin half of an asymmetric vacuum solve.This writes it as
grpmn_cosandbvec_cosat the four sites that dump either array, under the existinglasymguard, and adds the matchingadd_null("grpmn_cos")wheregrpmnis already nulled forivacskip /= 0. The existing keys are untouched, so anything reading the current output is unaffected.Checked on a free-boundary
lasym = Tcth-like case atns = 15,mpol = 5,ntor = 4,nfp = 5:vac1n_analyt,vac1n_fourpandvac1n_fourieach gain the cos key, and VMEC++ reproduces both halves to 1e-9.