Skip to content

Add login rejection detail, if present - #968

Merged
jpdillingham merged 2 commits into
masterfrom
login-detail
Sep 1, 2026
Merged

Add login rejection detail, if present#968
jpdillingham merged 2 commits into
masterfrom
login-detail

Conversation

@jpdillingham

Copy link
Copy Markdown
Owner

Reviewing the Nicotine+ docs, I realized that there's an extra string "detail" if login is rejected because of a bad username. This PR adds support for reading it, and appends it to the rejection reason if present. It also clarifies the Message property, which gives a MOTD message when login is successful and is not strictly used to communicate a rejection reason as previously stated.

@sonarqubecloud

sonarqubecloud Bot commented Sep 1, 2026

Copy link
Copy Markdown

@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.19%. Comparing base (8e260ea) to head (847f5ff).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #968      +/-   ##
==========================================
+ Coverage   99.16%   99.19%   +0.03%     
==========================================
  Files         189      189              
  Lines        6704     6707       +3     
  Branches     1024     1026       +2     
==========================================
+ Hits         6648     6653       +5     
+ Misses         42       41       -1     
+ Partials       14       13       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jpdillingham
jpdillingham merged commit 7aa266d into master Sep 1, 2026
5 checks passed
@jpdillingham
jpdillingham deleted the login-detail branch September 1, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant