Conversation
565a632 to
a5d89d4
Compare
|
@jub0t All checks should be green. Tested/confirmed on codespace. Of course if the proposed related PRs (175 and 179) don't address future project vision as these are UI changes along with project resolution ratios and additional resolution export ratios, let me know so I can withdraw/close them. This is the fmt fix for the effects-expansion merge (#180) — the files below went in unformatted, and every PR based on main now fails
No semantic change; a Three PRs of mine (#175, #178, #179) are blocked by this — they fail It would be worth a check on the merge path for #180 PR as those files on main if passed CI on its own branch, but landed with fmt dirty. A pre-merge hook or a stricter gate would have caught it before main went red for everyone else. |
|
Withdrawn as related PRs have been closed. |
Problem
cargo fmt --checkfails on main after the recent merges — the effects expansion (#159) and the advanced export (#143) left files that the check flags.Every PR based on main fails the same check on the same lines.
The files involved:
crates/concat/src/studio.rscrates/concat-effects/examples/previews.rscrates/concat-effects/src/manifest.rscrates/concat-effects/src/shader.rscrates/concat-export/src/lib.rscrates/concat-export/src/resolve.rscrates/concat-host/src/titles.rscrates/concat-media/src/encode.rscrates/concat-perf/src/main.rscrates/concat-render/src/gpu/tests.rsFix
cargo fmton the workspace. No semantic change; this only brings thefiles onto fmt so the check passes on main.
Why it matters
Every PR based on main fails
cargo fmt --checkon these files. Thisunblocks them without each branch carrying a fmt commit of its own.