Skip to content

style: cargo fmt on the workspace after the recent merges - #176

Closed
Domica wants to merge 1 commit into
jub0t:mainfrom
Domica:fix/cargo-fmt-effects
Closed

Domica wants to merge 1 commit into
jub0t:mainfrom
Domica:fix/cargo-fmt-effects

Conversation

@Domica

@Domica Domica commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Problem

cargo fmt --check fails on main after the recent merges — the effects expansion (#159) and the advanced export (#143) left files that the check flags.

Every PR based on main fails the same check on the same lines.

The files involved:

  • crates/concat/src/studio.rs
  • crates/concat-effects/examples/previews.rs
  • crates/concat-effects/src/manifest.rs
  • crates/concat-effects/src/shader.rs
  • crates/concat-export/src/lib.rs
  • crates/concat-export/src/resolve.rs
  • crates/concat-host/src/titles.rs
  • crates/concat-media/src/encode.rs
  • crates/concat-perf/src/main.rs
  • crates/concat-render/src/gpu/tests.rs

Fix

cargo fmt on the workspace. No semantic change; this only brings the
files onto fmt so the check passes on main.

Why it matters

Every PR based on main fails cargo fmt --check on these files. This
unblocks them without each branch carrying a fmt commit of its own.

cargo fmt --check fails on main for files left behind by the effects
expansion (jub0t#159) and the advanced export (jub0t#143) merges. This brings
them onto fmt so the check passes on main and for every branch based
on it.
@Domica
Domica force-pushed the fix/cargo-fmt-effects branch from 565a632 to a5d89d4 Compare September 22, 2026 19:22
@Domica

Domica commented Sep 22, 2026

Copy link
Copy Markdown
Contributor Author

@jub0t All checks should be green.

Tested/confirmed on codespace. Of course if the proposed related PRs (175 and 179) don't address future project vision as these are UI changes along with project resolution ratios and additional resolution export ratios, let me know so I can withdraw/close them.

This is the fmt fix for the effects-expansion merge (#180) — the files below went in unformatted, and every PR based on main now fails cargo fmt --check on the same lines:

  • crates/concat-effects/examples/previews.rs
  • crates/concat-effects/src/manifest.rs
  • crates/concat-effects/src/shader.rs
  • crates/concat-host/src/titles.rs
  • crates/concat-render/src/gpu/tests.rs
  • crates/concat-speech/src/chatterbox.rs

No semantic change; a cargo fmt on the workspace.

Three PRs of mine (#175, #178, #179) are blocked by this — they fail cargo fmt --check on the same two files even though their own code is clean. Once this lands, I can rebase them and they will pass check and be green.

It would be worth a check on the merge path for #180 PR as those files on main if passed CI on its own branch, but landed with fmt dirty. A pre-merge hook or a stricter gate would have caught it before main went red for everyone else.

@Domica

Domica commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author

Withdrawn as related PRs have been closed.

@Domica Domica closed this Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant