Beamrider: first submission#217
Open
xray2moon wants to merge 2 commits into
Open
Conversation
Closed
|
Review for Beamrider (second try 😄) ALE Similarity 4/4 Overall the game looks very good, almost indistinguishable from the original. The slower pace I mentioned before leads to the strobing effect on level start to be more intense than in the original, that is the only thing I have noticed, great work 👍 Implementation Quality 4/4 The other noticeable issue with the implementation is that it takes over a minute for the game to load on my machine with a discrete Nvidia GPU. Any game of some complexity will take time to compile with Jax, but this seems excessive. Apart from these minor issues the code looks clean and performs very well in game. |
|
Review of Beamrider from: Tenzing Dorjee Sherpa (Tictactoe3D) ALE Similarity: 3.5/4 Implementation Quality: 3/4 |
Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ✅There are no forbidden file changes. Nice 👍 Framework Tests ❌Some framework tests failed. Please check the details below: beamrider ❌This log was automatically created at 2026-02-15 14:51:25 UTC. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full Beamrider implementation. Like in the ALE, the game is done after beating sector 14. All enemies and obstacles have been implemented.
In the ALE, there is always one frame player+blue lines movement, next frame enemy movement. Should we also reproduce this in our game? We feel that it makes the gaming experience noticeably worse.
For convenience, we added WASD movement.
Controls:
Movement: LEFT ARROW, A; RIGHT ARROW, D
Laser: SPACE
TORPEDO: UP ARROW
The Fork that we worked on that contains our commit history : https://github.com/gixerl/JAXAtari_BeamRider (latest branch: refactor)
For some reason, the changed Files Test always failed when trying to open a PR from that Fork.
(locally the tests ran through after 3 minutes when ran in parallel. Not sure why it didn't work here)