Repository navigation
Report an NVIDIA adapter on the Metal renderer so dynamic shadows render - #21
Merged
Merged
Conversation
With the Apple vendor id (0x106b), Source's shaderapivk turns off shadow depth textures (r_flashlightdepthtexture 0, r_flashlightdepthres 0), so dynamic lights cast no shadows on the Metal renderer while OpenGL has them (issue #20). With 0x10de both cvars match OpenGL. P2_D3D9_VENDOR_ID still overrides the default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20.
With the Apple vendor id (
0x106b), Source'sshaderapivkturns off shadow depth textures, so dynamic lights cast no shadows on Metal. OpenGL has them.r_flashlightdepthtexturer_flashlightdepthres106b(before)10de(this PR)The default becomes NVIDIA (
10de).P2_D3D9_VENDOR_IDstill overrides it.Frame rate, Metal, 1440p MSAA 4, 3 alternating rounds: 62.8 fps with
106b, 63.6 with10de, within noise.Tests:
make checkpasses; the updated assertions intests/checks_d3d9.cfail on the old default.Not tested: iPhone, and play beyond a few rooms on Mac.
🤖 Generated with Claude Code