Skip to content

[hooks-upgrade]: Upgrade stale hook plugins before reporting success - #95

Merged
archae0pteryx merged 1 commit into
mainfrom
fix/upgrade-hooks-plugin
Oct 21, 2026
Merged

archae0pteryx merged 1 commit into
mainfrom
fix/upgrade-hooks-plugin

Conversation

@archae0pteryx

Copy link
Copy Markdown
Contributor

Install Hooks could accept an older Ranch plugin when its hook handlers and wrapper matched the app. With version 0.1.0 installed, the button could merely enable it even though Ranch bundles 0.1.1.

Require the plugin manifest version to match the manifest embedded in the app, alongside the existing identity, handler, wrapper, and executable checks. This routes stale versions through the existing marketplace refresh and user-scoped update/verification flow. The bundled manifest remains the single source of truth; no dependency or separate version constant is added.

A current valid installation remains untouched. A marketplace copy that cannot satisfy the app's full contract fails validation before the existing reinstall path removes anything. Version matching is exact, just like the existing wrapper contract; this does not promise compatibility with newer plugin releases running against an older app.

No separate issue file exists. This follows the installer investigation alongside #94; the startup correction remains a separate PR.

Validation:

  • The new upgrade regression failed before the fix because no update occurred; it now verifies both enabled and disabled older installations are upgraded and enabled.
  • The outdated/missing-version regression also failed before the fix and now passes.
  • All 22 plugin tests passed.
  • task check passed, including Rust/frontend tests, lint, release/debug Clippy, build/type checks and generated-contract checks.
  • task check:windows passed. The existing Unix-only script variable warning remains, along with the intentional cross-check placeholder-sidecar notice.
  • Base remains 7900cc445ac224464e254b31d4914b0a52055270.

Tests use temporary plugin copies and a fake Claude CLI boundary. No personal Claude settings, plugin installation, or enabled state was changed. A live Install Hooks click and Claude-to-Ranch session delivery remain untested.

@archae0pteryx

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: killallgit/adhd-ranch/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: fa86cd57-30ef-448e-847f-78fe7393e515

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@archae0pteryx

Copy link
Copy Markdown
Contributor Author

Independent fallback review of commit 0132a4f3b44b7c47190712b3f05fc9840c33d79f (CodeRabbit reported its review quota exhausted):

A separate fresh-context reviewer examined the complete diff, installer lifecycle and status callers, idempotence/error tests, CLAUDE.md, and .coderabbit.yaml. No actionable findings.

The reviewer confirmed that old complete plugins enter the existing upgrade flow, both enabled/disabled cases are covered, the refreshed marketplace is validated before any uninstall, and current valid installations retain the no-update path. Exact compatibility also rejects newer plugin versions; this introduces no unsafe write path.

Author-run checks passed: all 22 plugin tests, task check, and task check:windows. Both new regression tests were observed failing before the fix and passing afterward. The independent reviewer did not rerun these gates or perform a live Claude installation. Personal plugin/settings state remains unchanged. CI is still running; this PR remains open and is not merged.

@archae0pteryx
archae0pteryx force-pushed the fix/upgrade-hooks-plugin branch from 0132a4f to 450f27e Compare October 21, 2026 20:33
@archae0pteryx

Copy link
Copy Markdown
Contributor Author

Updated against main at 07483f3413043c4882917adb8efe044979175657; reviewed head: 450f27ea085beded00ce11bf7badec134b38f0c3.

  • Rebase was conflict-free and patch-identical to the original PR: two files, 93 insertions.
  • Fresh independent behavior review: PASS, no findings. Full diff, validator/install/status callers, and enabled/disabled upgrade regressions inspected. Reviewer independently reran task check and task check:windows.
  • Fresh independent rules review: clean across both changed files and their immediate callers/callees/tests.
  • Author and reviewer gates passed, including 336 Rust tests, 178 frontend tests, generated-contract checks, and the Windows cross-check.
  • No tests weakened, checks silenced, unrelated changes added, or personal Claude/plugin settings changed.

Live Install Hooks interaction and Claude-to-Ranch delivery remain unverified; this merge does not certify those manual checks or publish a release.

@archae0pteryx
archae0pteryx merged commit 67140af into main Oct 21, 2026
2 checks passed
@archae0pteryx
archae0pteryx deleted the fix/upgrade-hooks-plugin branch October 21, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant