Repository navigation
[hooks-upgrade]: Upgrade stale hook plugins before reporting success - #95
Conversation
|
@coderabbitai review |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
Independent fallback review of commit A separate fresh-context reviewer examined the complete diff, installer lifecycle and status callers, idempotence/error tests, The reviewer confirmed that old complete plugins enter the existing upgrade flow, both enabled/disabled cases are covered, the refreshed marketplace is validated before any uninstall, and current valid installations retain the no-update path. Exact compatibility also rejects newer plugin versions; this introduces no unsafe write path. Author-run checks passed: all 22 plugin tests, |
0132a4f to
450f27e
Compare
|
Updated against
Live Install Hooks interaction and Claude-to-Ranch delivery remain unverified; this merge does not certify those manual checks or publish a release. |
Install Hooks could accept an older Ranch plugin when its hook handlers and wrapper matched the app. With version 0.1.0 installed, the button could merely enable it even though Ranch bundles 0.1.1.
Require the plugin manifest version to match the manifest embedded in the app, alongside the existing identity, handler, wrapper, and executable checks. This routes stale versions through the existing marketplace refresh and user-scoped update/verification flow. The bundled manifest remains the single source of truth; no dependency or separate version constant is added.
A current valid installation remains untouched. A marketplace copy that cannot satisfy the app's full contract fails validation before the existing reinstall path removes anything. Version matching is exact, just like the existing wrapper contract; this does not promise compatibility with newer plugin releases running against an older app.
No separate issue file exists. This follows the installer investigation alongside #94; the startup correction remains a separate PR.
Validation:
task checkpassed, including Rust/frontend tests, lint, release/debug Clippy, build/type checks and generated-contract checks.task check:windowspassed. The existing Unix-onlyscriptvariable warning remains, along with the intentional cross-check placeholder-sidecar notice.7900cc445ac224464e254b31d4914b0a52055270.Tests use temporary plugin copies and a fake Claude CLI boundary. No personal Claude settings, plugin installation, or enabled state was changed. A live Install Hooks click and Claude-to-Ranch session delivery remain untested.