fix: correct search, navigation, and catalog checks - #1
Merged
kishormorol merged 4 commits intoSep 12, 2026
Merged
kishormorol merged 4 commits into
kishormorol merged 4 commits into
Conversation
kishormorol
added a commit
that referenced
this pull request
Sep 12, 2026
TestCase.enterContext landed in 3.11, so the nine new source-checker tests errored out with AttributeError on 3.10. CI pins 3.12 and stayed green, which hid the raised floor. Swap in start()/addCleanup, which behaves identically and works everywhere. Follow-up to the source-checker tests WhiteHades contributed in #1; the tests and the behaviour they cover are theirs, this only lowers the interpreter floor back to 3.10. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018rw2KxMtReyjCJDwrgVtZR
kishormorol
added a commit
that referenced
this pull request
Sep 12, 2026
Add an acknowledgements section naming WhiteHades for the search, accessibility, route, source, and validation fixes in #1, so the credit survives however the pull request is merged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018rw2KxMtReyjCJDwrgVtZR
Owner
|
Thanks for this — it's a careful piece of work, and the write-up made it easy to check. I fetched the branch and ran everything:
A few notes on the fixes themselves:
Two follow-ups from my side:
Everything else looks good to merge. I'll merge without squashing so your commits keep their authorship, and I've added an acknowledgements section to the README. |
WhiteHades
pushed a commit
to WhiteHades/agent-command-atlas
that referenced
this pull request
Sep 12, 2026
TestCase.enterContext landed in 3.11, so the nine new source-checker tests errored out with AttributeError on 3.10. CI pins 3.12 and stayed green, which hid the raised floor. Swap in start()/addCleanup, which behaves identically and works everywhere. Follow-up to the source-checker tests WhiteHades contributed in kishormorol#1; the tests and the behaviour they cover are theirs, this only lowers the interpreter floor back to 3.10. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018rw2KxMtReyjCJDwrgVtZR
WhiteHades
pushed a commit
to WhiteHades/agent-command-atlas
that referenced
this pull request
Sep 12, 2026
Add an acknowledgements section naming WhiteHades for the search, accessibility, route, source, and validation fixes in kishormorol#1, so the credit survives however the pull request is merged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018rw2KxMtReyjCJDwrgVtZR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr adds:
-hranks help above-Hheaderschecks:
python scripts/validate.pypython -m unittest discover -s testsnode --check site/app.jsnode tests/test_site_search.jspython scripts/build_catalog.pyThe HTML changes regenerate tracked pages with corrected skip links and updated asset hashes. The catalog still contains 2,604 entries and 33 capabilities. Muse version and help output were inspected and the executable matched the release manifest; individual Muse entries remain documentation-backed.