Add more AC controls: HVAC mode and fan mode - #6
Merged
Conversation
Owner
|
@manuelseeger Thank you for your PR! This fixes the issue reported here, as my fix turned out to be incomplete. Few comments:
so we have buttons with labels like "Fan_only". I think we should have dedicated function in Model to convert values to visible lables, like: Let me know what you think and whether it's possible to implement corrections to the PR, I'd be happy to merge it. |
Closed
Makes all controls accessible by keyboard.
Contributor
Author
Owner
|
@manuelseeger Thank you for your fixes! Looks great. I will merge this PR. Your comment about the dropdown is valid, but maybe it should be reported to the omarchy repo? I don't think it's intentional for this field as qt docs recommends using plaintext for untrusted content. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Added generic Home Assistant climate controls:
Home assistant knows more controls like fan swing, presets, target humidity, and more. I did not add these to not overload the HVAC widget.