Skip to content

Fix public-safety scan after Code of Conduct update - #7

Merged
ksudo-dev merged 4 commits into
mainfrom
fix/public-safety-code-of-conduct
Oct 16, 2026
Merged

ksudo-dev merged 4 commits into
mainfrom
fix/public-safety-code-of-conduct

Conversation

@ksudo-dev

Copy link
Copy Markdown
Owner

What this fixes

  • keeps the Contributor Code of Conduct current without weakening the public-data scan
  • pins historical fixture allowances to exact blobs, paths, rules, and values
  • documents why those historical test fixtures are allowed
  • adds regression coverage so broad or stale allowances fail

Verified locally

  • git diff --check origin/main...HEAD
  • node --test test/public-data-scan.test.js — 2 passed
  • node scripts/public-data-scan.mjs — passed across 26 commits and the working tree

Scope

This PR fixes the failed public-safety job only. The household Provisionarr request/download failure is being diagnosed separately and will not be deployed until a controlled end-to-end request is proven. This separation keeps the CI repair reviewable and prevents an unverified runtime fix from being hidden inside policy changes.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T02:42:12.514199Z bf90e59 PR opened
🔒 Security Review ✅ Completed 2026-10-16T02:42:16.587687Z bf90e59 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bf90e59e04

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

rule.regex.lastIndex = 0;
for (const match of text.matchAll(rule.regex)) {
if (rule.allow?.(match[0])) continue;
if (rule.allow?.(match[0]) || isHistoricalPublicDataAllowance({rule:rule.name, path, value:match[0], blob})) continue;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Deduplicate allowlisted blobs by path

When an allowlisted historical blob exists at both its approved path and another path on a retained non-HEAD ref, the approved path can be scanned first and the global seenBlobs check then skips the second occurrence entirely. For example, placing blob 4019fb0... at both CODE_OF_CONDUCT.md and z-copy/CODE_OF_CONDUCT.md makes the scanner pass even though the latter path is not allowed, contradicting the exact-path guarantee. Include the path in the deduplication key or reevaluate path-sensitive allowances for every occurrence.

Useful? React with 👍 / 👎.

@ksudo-dev
ksudo-dev merged commit ac10960 into main Oct 16, 2026
7 checks passed
@ksudo-dev
ksudo-dev deleted the fix/public-safety-code-of-conduct branch October 16, 2026 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants