Repository navigation
Fix public-safety scan after Code of Conduct update - #7
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bf90e59e04
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| rule.regex.lastIndex = 0; | ||
| for (const match of text.matchAll(rule.regex)) { | ||
| if (rule.allow?.(match[0])) continue; | ||
| if (rule.allow?.(match[0]) || isHistoricalPublicDataAllowance({rule:rule.name, path, value:match[0], blob})) continue; |
There was a problem hiding this comment.
Deduplicate allowlisted blobs by path
When an allowlisted historical blob exists at both its approved path and another path on a retained non-HEAD ref, the approved path can be scanned first and the global seenBlobs check then skips the second occurrence entirely. For example, placing blob 4019fb0... at both CODE_OF_CONDUCT.md and z-copy/CODE_OF_CONDUCT.md makes the scanner pass even though the latter path is not allowed, contradicting the exact-path guarantee. Include the path in the deduplication key or reevaluate path-sensitive allowances for every occurrence.
Useful? React with 👍 / 👎.
What this fixes
Verified locally
git diff --check origin/main...HEADnode --test test/public-data-scan.test.js— 2 passednode scripts/public-data-scan.mjs— passed across 26 commits and the working treeScope
This PR fixes the failed public-safety job only. The household Provisionarr request/download failure is being diagnosed separately and will not be deployed until a controlled end-to-end request is proven. This separation keeps the CI repair reviewable and prevents an unverified runtime fix from being hidden inside policy changes.