Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
with:
fetch-depth: 0
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7
with:
node-version: 22
Expand Down
268 changes: 152 additions & 116 deletions CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
@@ -1,128 +1,164 @@
# Contributor Covenant Code of Conduct
# Contributor Covenant 3.0 Code of Conduct

## Our Pledge

We as members, contributors, and leaders pledge to make participation in our
community a harassment-free experience for everyone, regardless of age, body
size, visible or invisible disability, ethnicity, sex characteristics, gender
identity and expression, level of experience, education, socio-economic status,
nationality, personal appearance, race, religion, or sexual identity
and orientation.

We pledge to act and interact in ways that contribute to an open, welcoming,
diverse, inclusive, and healthy community.

## Our Standards

Examples of behavior that contributes to a positive environment for our
community include:

* Demonstrating empathy and kindness toward other people
* Being respectful of differing opinions, viewpoints, and experiences
* Giving and gracefully accepting constructive feedback
* Accepting responsibility and apologizing to those affected by our mistakes,
and learning from the experience
* Focusing on what is best not just for us as individuals, but for the
overall community

Examples of unacceptable behavior include:

* The use of sexualized language or imagery, and sexual attention or
advances of any kind
* Trolling, insulting or derogatory comments, and personal or political attacks
* Public or private harassment
* Publishing others' private information, such as a physical or email
address, without their explicit permission
* Other conduct which could reasonably be considered inappropriate in a
professional setting

## Enforcement Responsibilities

Community leaders are responsible for clarifying and enforcing our standards of
acceptable behavior and will take appropriate and fair corrective action in
response to any behavior that they deem inappropriate, threatening, offensive,
or harmful.

Community leaders have the right and responsibility to remove, edit, or reject
comments, commits, code, wiki edits, issues, and other contributions that are
not aligned to this Code of Conduct, and will communicate reasons for moderation
decisions when appropriate.
We pledge to make our community welcoming, safe, and equitable for all.

We are committed to fostering an environment that respects and promotes the
dignity, rights, and contributions of all individuals, regardless of
characteristics including race, ethnicity, caste, color, age, physical
characteristics, neurodiversity, disability, sex or gender, gender identity or
expression, sexual orientation, language, philosophy or religion, national or
social origin, socio-economic position, level of education, or other status.

The same privileges of participation are extended to everyone who participates
in good faith and in accordance with this Covenant.

## Encouraged Behaviors

While acknowledging differences in social norms, we all strive to meet our
community's expectations for positive behavior. We also understand that our
words and actions may be interpreted differently than we intend based on
culture, background, or native language.

With these considerations in mind, we agree to behave mindfully toward each
other and act in ways that center our shared values, including:

1. Respecting the **purpose of our community**, our activities, and our ways of
gathering.
2. Engaging **kindly and honestly** with others.
3. Respecting **different viewpoints** and experiences.
4. **Taking responsibility** for our actions and contributions.
5. Gracefully giving and accepting **constructive feedback**.
6. Committing to **repairing harm** when it occurs.
7. Behaving in other ways that promote and sustain the **well-being of our
community**.

## Restricted Behaviors

We agree to restrict the following behaviors in our community. Instances,
threats, and promotion of these behaviors are violations of this Code of
Conduct.

1. **Harassment.** Violating explicitly expressed boundaries or engaging in
unnecessary personal attention after any clear request to stop.
2. **Character attacks.** Making insulting, demeaning, or pejorative comments
directed at a community member or group of people.
3. **Stereotyping or discrimination.** Characterizing anyone's personality or
behavior on the basis of immutable identities or traits.
4. **Sexualization.** Behaving in a way that would generally be considered
inappropriately intimate in the context or purpose of the community.
5. **Violating confidentiality.** Sharing or acting on someone's personal or
private information without their permission.
6. **Endangerment.** Causing, encouraging, or threatening violence or other
harm toward any person or group.
7. Behaving in other ways that **threaten the well-being** of our community.

### Other Restrictions

1. **Misleading identity.** Impersonating someone else for any reason, or
pretending to be someone else to evade enforcement actions.
2. **Failing to credit sources.** Not properly crediting the sources of content
you contribute.
3. **Promotional materials.** Sharing marketing or other commercial content in
a way that is outside the norms of the community.
4. **Irresponsible communication.** Failing to responsibly present content
which includes, links, or describes any other restricted behaviors.

## Reporting an Issue

Tensions can occur between community members even when they are trying their
best to collaborate. Not every conflict represents a code of conduct violation,
and this Code of Conduct reinforces encouraged behaviors and norms that can
help avoid conflicts and minimize harm.

When an incident does occur, it is important to report it promptly. To report a
possible violation privately, use Provisionarr's
[private report form](https://github.com/ksudo-dev/provisionarr/security/advisories/new).
Begin the report title with `Code of Conduct report:` and include the relevant
dates, locations, and available evidence. Do not include sensitive details in a
public issue.

Community Moderators take reports of violations seriously and will make every
effort to respond in a timely manner. They will investigate all reports of code
of conduct violations, reviewing messages, logs, and recordings, or
interviewing witnesses and other participants. Community Moderators will keep
investigation and enforcement actions as transparent as possible while
prioritizing safety and confidentiality.

In order to honor these values, enforcement actions are carried out in private
with the involved parties, but communicating to the whole community may be part
of a mutually agreed upon resolution.

## Addressing and Repairing Harm

If an investigation by the Community Moderators finds that this Code of Conduct
has been violated, the following enforcement ladder may be used to determine
how best to repair harm, based on the incident's impact on the individuals
involved and the community as a whole. Depending on the severity of a
violation, lower rungs on the ladder may be skipped.

1. **Warning**
- **Event:** A violation involving a single incident or series of incidents.
- **Consequence:** A private, written warning from the Community Moderators.
- **Repair:** Examples include a private written apology, acknowledgement of
responsibility, and seeking clarification on expectations.
2. **Temporarily Limited Activities**
- **Event:** A repeated incidence of a violation that previously resulted in
a warning, or the first incidence of a more serious violation.
- **Consequence:** A private, written warning with a time-limited cooldown
period designed to underscore the seriousness of the situation and give
the community members involved time to process the incident. The cooldown
period may be limited to particular communication channels or interactions
with particular community members.
- **Repair:** Examples include making an apology, using the cooldown period
to reflect on actions and impact, and being thoughtful about re-entering
community spaces after the period is over.
3. **Temporary Suspension**
- **Event:** A pattern of repeated violation which the Community Moderators
have tried to address with warnings, or a single serious violation.
- **Consequence:** A private written warning with conditions for return from
suspension. In general, temporary suspensions give the person being
suspended time to reflect upon their behavior and possible corrective
actions.
- **Repair:** Examples include respecting the spirit of the suspension,
meeting the specified conditions for return, and being thoughtful about
how to reintegrate with the community when the suspension is lifted.
4. **Permanent Ban**
- **Event:** A pattern of repeated code of conduct violations that other
steps on the ladder have failed to resolve, or a violation so serious that
the Community Moderators determine there is no way to keep the community
safe with this person as a member.
- **Consequence:** Access to all community spaces, tools, and communication
channels is removed. In general, permanent bans should be rarely used,
should have strong reasoning behind them, and should only be resorted to
if working through other remedies has failed to change the behavior.
- **Repair:** There is no possible repair in cases of this severity.

This enforcement ladder is intended as a guideline. It does not limit the
ability of Community Managers to use their discretion and judgment, in keeping
with the best interests of our community.

## Scope

This Code of Conduct applies within all community spaces, and also applies when
an individual is officially representing the community in public spaces.
Examples of representing our community include using an official e-mail address,
posting via an official social media account, or acting as an appointed
representative at an online or offline event.

## Enforcement

Instances of abusive, harassing, or otherwise unacceptable behavior may be
reported to the community leaders responsible for enforcement at
k@sudo-dev.com.
All complaints will be reviewed and investigated promptly and fairly.

All community leaders are obligated to respect the privacy and security of the
reporter of any incident.

## Enforcement Guidelines

Community leaders will follow these Community Impact Guidelines in determining
the consequences for any action they deem in violation of this Code of Conduct:

### 1. Correction

**Community Impact**: Use of inappropriate language or other behavior deemed
unprofessional or unwelcome in the community.

**Consequence**: A private, written warning from community leaders, providing
clarity around the nature of the violation and an explanation of why the
behavior was inappropriate. A public apology may be requested.

### 2. Warning

**Community Impact**: A violation through a single incident or series
of actions.

**Consequence**: A warning with consequences for continued behavior. No
interaction with the people involved, including unsolicited interaction with
those enforcing the Code of Conduct, for a specified period of time. This
includes avoiding interactions in community spaces as well as external channels
like social media. Violating these terms may lead to a temporary or
permanent ban.

### 3. Temporary Ban

**Community Impact**: A serious violation of community standards, including
sustained inappropriate behavior.

**Consequence**: A temporary ban from any sort of interaction or public
communication with the community for a specified period of time. No public or
private interaction with the people involved, including unsolicited interaction
with those enforcing the Code of Conduct, is allowed during this period.
Violating these terms may lead to a permanent ban.

### 4. Permanent Ban

**Community Impact**: Demonstrating a pattern of violation of community
standards, including sustained inappropriate behavior, harassment of an
individual, or aggression toward or disparagement of classes of individuals.

**Consequence**: A permanent ban from any sort of public interaction within
the community.
an individual is officially representing the community in public or other
spaces. Examples of representing our community include using an official email
address, posting via an official social media account, or acting as an
appointed representative at an online or offline event.

## Attribution

This Code of Conduct is adapted from the [Contributor Covenant][homepage],
version 2.0, available at
https://www.contributor-covenant.org/version/2/0/code_of_conduct.html.

Community Impact Guidelines were inspired by [Mozilla's code of conduct
enforcement ladder](https://github.com/mozilla/diversity).
This Code of Conduct is adapted from the Contributor Covenant, version 3.0,
permanently available at
[https://www.contributor-covenant.org/version/3/0/](https://www.contributor-covenant.org/version/3/0/).

[homepage]: https://www.contributor-covenant.org
Contributor Covenant is stewarded by the Organization for Ethical Source and
licensed under [CC BY-SA 4.0](https://creativecommons.org/licenses/by-sa/4.0/).
For answers to common questions, see the
[Contributor Covenant FAQ](https://www.contributor-covenant.org/faq).
Translations and additional resources are available from the
[Contributor Covenant website](https://www.contributor-covenant.org/).

For answers to common questions about this code of conduct, see the FAQ at
https://www.contributor-covenant.org/faq. Translations are available at
https://www.contributor-covenant.org/translations.
The enforcement ladder was inspired by the work of
[Mozilla's code of conduct team](https://github.com/mozilla/inclusion).
21 changes: 21 additions & 0 deletions docs/PUBLIC-SAFETY-FIXTURES.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# Historical public-data allowances

The public-data scanner checks every reachable Git ref. Two old
`test/discovery-catalog.test.js` fixtures intentionally model security
boundaries and match generic deployment-data detectors:

- `192.168.50.` followed by `9` is the synthetic non-loopback target used to verify that
fixture-only administration rejects non-loopback services.
- `user` followed by `@static.tvmaze.com` is the synthetic URL-userinfo form used to verify
that TVmaze poster validation rejects credentials in an image URL.

The original Contributor Covenant 2.0 commit also contained a direct maintainer
email address. The current Contributor Covenant 3.0 document uses the private
GitHub report form instead. Rewriting public history would be disruptive, so
the old email is allowed only in that exact historical blob.

The scanner allows only those exact values at their exact paths and in the
exact historical Git blobs that contain them. It continues to reject other
private addresses, all other personal-email forms, tokens, and even matching
values in the working tree or a different blob, including on reachable
non-HEAD refs.
37 changes: 37 additions & 0 deletions scripts/public-data-fixture-allowances.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
const historicalPublicDataAllowances = [
{
path: 'test/discovery-catalog.test.js',
rule: 'private IPv4 address',
value: ['192', '168', '50', '9'].join('.'),
blobs: new Set([
['147f6e2ff758f003', 'b031b0943dd64897', '32a20376'].join(''),
['2f449baf8b1c5b64', '8bdd6f0c2247db62', 'bb9a74fa'].join(''),
['bc20d8769840db64', '7d729502a01258fd', '23b05747'].join(''),
]),
},
{
path: 'test/discovery-catalog.test.js',
rule: 'personal email address',
value: 'user' + '@' + 'static.tvmaze.com',
blobs: new Set([
['147f6e2ff758f003', 'b031b0943dd64897', '32a20376'].join(''),
['bc20d8769840db64', '7d729502a01258fd', '23b05747'].join(''),
]),
},
{
path: 'CODE_OF_CONDUCT.md',
rule: 'personal email address',
value: 'k' + '@' + 'sudo-dev.com',
blobs: new Set([
['4019fb0c4429b3cf', '741966de610b0242', '2060f809'].join(''),
]),
},
];

// Historical allowances are pinned to the exact blob, path, rule, and value.
// Working-tree matches have no blob identity and must remain findings.
export function isHistoricalPublicDataAllowance({rule, path, value, blob}) {
return Boolean(blob) && historicalPublicDataAllowances.some(allowance =>
allowance.path === path && allowance.rule === rule && allowance.value === value && allowance.blobs.has(blob)
);
}
12 changes: 7 additions & 5 deletions scripts/public-data-scan.mjs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { execFileSync } from 'node:child_process';
import { readFileSync } from 'node:fs';
import { join } from 'node:path';
import { isHistoricalPublicDataAllowance } from './public-data-fixture-allowances.mjs';

const root = execFileSync('git', ['rev-parse', '--show-toplevel'], { encoding: 'utf8' }).trim();
const findings = [];
Expand Down Expand Up @@ -34,12 +35,12 @@ const rules = [
},
];

function scanText(ref, path, text) {
function scanText(ref, path, text, blob) {
if (text.includes('\0')) return;
for (const rule of rules) {
rule.regex.lastIndex = 0;
for (const match of text.matchAll(rule.regex)) {
if (rule.allow?.(match[0])) continue;
if (rule.allow?.(match[0]) || isHistoricalPublicDataAllowance({rule:rule.name, path, value:match[0], blob})) continue;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Deduplicate allowlisted blobs by path

When an allowlisted historical blob exists at both its approved path and another path on a retained non-HEAD ref, the approved path can be scanned first and the global seenBlobs check then skips the second occurrence entirely. For example, placing blob 4019fb0... at both CODE_OF_CONDUCT.md and z-copy/CODE_OF_CONDUCT.md makes the scanner pass even though the latter path is not allowed, contradicting the exact-path guarantee. Include the path in the deduplication key or reevaluate path-sensitive allowances for every occurrence.

Useful? React with 👍 / 👎.

const line = text.slice(0, match.index).split('\n').length;
findings.push({ rule: rule.name, ref, path, line });
}
Expand Down Expand Up @@ -72,10 +73,11 @@ for (const commit of commits) {
const [metadata, path] = entry.split('\t');
if (!metadata || !path) continue;
const [, type, blob] = metadata.split(' ');
if (type !== 'blob' || seenBlobs.has(blob)) continue;
seenBlobs.add(blob);
const blobAtPath = `${blob}\0${path}`;
if (type !== 'blob' || seenBlobs.has(blobAtPath)) continue;
seenBlobs.add(blobAtPath);
const content = gitText(['show', `${commit}:${path}`], null).toString('utf8');
scanText(commit.slice(0, 12), path, content);
scanText(commit.slice(0, 12), path, content, blob);
scanReleasePolicy(commit.slice(0, 12), path, content);
}
}
Expand Down
Loading
Loading