Retain order of domains#80
Open
zx2c4 wants to merge 1 commit intokuba:masterfrom
zx2c4:domain-order-cn
Open
Conversation
Closed
tox.ini
Outdated
| pip install -e .[tests] | ||
| pep8 simp_le.py | ||
| pylint --disable=locally-disabled,fixme simp_le | ||
| pylint --disable=locally-disabled,fixme,import-error simp_le |
Owner
There was a problem hiding this comment.
can you please do a local disable instead of updating tox.ini?
Owner
|
This is missing any kind of tests. |
Author
|
Okay, now it locally disables for the linter. Good thinking. I just took a look at how you're implementing the test suite. I can struggle and grunt to add the tests to the test suite here, and in the end I'm sure it won't fit your criteria for inclusion. Would you rather we do some iterations of me struggling, or could you just add this in five minutes yourself? |
This ensures that the first domain specified on the command line will be the domain that winds up in the CN field. Otherwise, users have no way of controlling this. Fixes: #72 Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Owner
|
I could try to write tests, but not in foreseeable future - unfortunately I'm extremely busy atm. If you're fine with waiting a couple of weeks before this get merged, then OK... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that the first domain specified on the command line will be the domain that winds up in the CN field. Otherwise, users have no way of controlling this.
This also supports Python 2.6, which is an improvement over the prior pull request. It also correctly tames pylint for an extremely widespread conditional import pattern.
It should pass all tests on Travis.
Fixes: #72
Signed-off-by: Jason A. Donenfeld Jason@zx2c4.com