Skip to content

Accessor: Re-link modal selector labels and fix radiogroup semantics - #1859

Open
kunkunGames wants to merge 4 commits into
mainfrom
jules/accessor/modal-accessibility-selectors-recreate-v3-8587043447853082141
Open

Accessor: Re-link modal selector labels and fix radiogroup semantics#1859
kunkunGames wants to merge 4 commits into
mainfrom
jules/accessor/modal-accessibility-selectors-recreate-v3-8587043447853082141

Conversation

@kunkunGames

Copy link
Copy Markdown
Owner

What changed:

  • Added id prop to EmojiPicker and passed it down to the underlying toggle button.
  • Updated AgentFormModal.tsx and DepartmentFormModal.tsx to use htmlFor pointing to the newly injected EmojiPicker IDs.
  • Converted an invalid <label id="dept-theme-color-label"> to a <div> inside a role="radiogroup" inside DepartmentFormModal.tsx.

Why:

  • Improves dashboard accessibility by correctly tying native HTML text labels to interactive, custom-built component triggers, ensuring screen reader focus and proper announcement behavior.
  • Resolves an ARIA invalidity issue where a <label> was erroneously used to label a radiogroup wrapper instead of an explicit input/control.

WorkFingerprint:

Verification:

  • git diff --check run successfully.
  • ./scripts/verify-dashboard.sh run successfully with passing UI tests (e.g., vitest run).
  • Checked that tests for modal accessibility components passed.

PR created automatically by Jules for task 8587043447853082141 started by @kunkunGames

Co-authored-by: kunkunGames <271022317+kunkunGames@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

google-labs-jules Bot and others added 3 commits September 4, 2026 04:47
Co-authored-by: kunkunGames <271022317+kunkunGames@users.noreply.github.com>
Co-authored-by: kunkunGames <271022317+kunkunGames@users.noreply.github.com>
Co-authored-by: kunkunGames <271022317+kunkunGames@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant