Accessor: Re-link modal selector labels and fix radiogroup semantics - #1859
Accessor: Re-link modal selector labels and fix radiogroup semantics#1859kunkunGames wants to merge 4 commits into
Conversation
Co-authored-by: kunkunGames <271022317+kunkunGames@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Co-authored-by: kunkunGames <271022317+kunkunGames@users.noreply.github.com>
Co-authored-by: kunkunGames <271022317+kunkunGames@users.noreply.github.com>
Co-authored-by: kunkunGames <271022317+kunkunGames@users.noreply.github.com>
What changed:
idprop toEmojiPickerand passed it down to the underlying toggle button.AgentFormModal.tsxandDepartmentFormModal.tsxto usehtmlForpointing to the newly injectedEmojiPickerIDs.<label id="dept-theme-color-label">to a<div>inside arole="radiogroup"insideDepartmentFormModal.tsx.Why:
<label>was erroneously used to label aradiogroupwrapper instead of an explicit input/control.WorkFingerprint:
main.Verification:
git diff --checkrun successfully../scripts/verify-dashboard.shrun successfully with passing UI tests (e.g.,vitest run).PR created automatically by Jules for task 8587043447853082141 started by @kunkunGames