Skip to content

Accessor: Re-link modal selector labels and fix radiogroup semantics #1859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kunkunGames wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Accessor: Re-link modal selector labels and fix radiogroup semantics #1859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf651bf
Accessor: Re-link modal selector labels and fix radiogroup semantics
google-labs-jules[bot] Sep 4, 2026
dec3869
Accessor: Re-link modal selector labels and fix radiogroup semantics
google-labs-jules[bot] Sep 4, 2026
9943629
Accessor: Re-link modal selector labels and fix radiogroup semantics
google-labs-jules[bot] Sep 4, 2026
a82e657
Accessor: Re-link modal selector labels and fix radiogroup semantics
google-labs-jules[bot] Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dashboard/src/components/agent-manager/AgentFormModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,10 +311,11 @@ export default function AgentFormModal({
)}
<div className="grid grid-cols-[72px_minmax(0,1fr)] gap-2 md:grid-cols-[72px_minmax(0,1fr)_minmax(0,1fr)]">
<div>
<label className="block text-xs mb-1.5 font-medium" style={{ color: "var(--th-text-secondary)" }}>
<label htmlFor="agent-emoji-picker" className="block text-xs mb-1.5 font-medium" style={{ color: "var(--th-text-secondary)" }}>
{tr("이모지", "Emoji")}
</label>
<EmojiPicker
id="agent-emoji-picker"
value={formValues.avatar_emoji}
onChange={(emoji) => setValue("avatar_emoji", emoji, { shouldDirty: true, shouldValidate: true })}
aria-label={
Expand Down
7 changes: 4 additions & 3 deletions dashboard/src/components/agent-manager/DepartmentFormModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,10 +312,11 @@ export default function DepartmentFormModal({
<div className="space-y-4">
<div className="flex items-start gap-3">
<div>
<label className="block text-xs mb-1.5 font-medium" style={{ color: "var(--th-text-secondary)" }}>
<label htmlFor="dept-icon-picker" className="block text-xs mb-1.5 font-medium" style={{ color: "var(--th-text-secondary)" }}>
{tr("아이콘", "Icon")}
</label>
<EmojiPicker
id="dept-icon-picker"
value={form.icon}
onChange={(emoji) => setValue("icon", emoji, { shouldDirty: true, shouldValidate: true })}
aria-label={
Expand Down Expand Up @@ -353,9 +354,9 @@ export default function DepartmentFormModal({
</div>

<div role="radiogroup" aria-labelledby="dept-theme-color-label">
<label id="dept-theme-color-label" className="block text-xs mb-1.5 font-medium" style={{ color: "var(--th-text-secondary)" }}>
<div id="dept-theme-color-label" className="block text-xs mb-1.5 font-medium" style={{ color: "var(--th-text-secondary)" }}>
{tr("테마 색상", "Theme Color")}
</label>
</div>
<div className="flex gap-2 flex-wrap">
{DEPT_COLORS.map((c, index) => (
<button
Expand Down
3 changes: 3 additions & 0 deletions dashboard/src/components/agent-manager/EmojiPicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,14 @@ export function StackedSpriteIcon({ sprites }: { sprites: [number, number] }) {
}

export default function EmojiPicker({
id,
value,
onChange,
size = "md",
"aria-label": ariaLabel,
dialogLabel,
}: {
id?: string;
value: string;
onChange: (emoji: string) => void;
size?: "sm" | "md";
Expand Down Expand Up @@ -86,6 +88,7 @@ export default function EmojiPicker({
return (
<div className="relative" ref={ref}>
<button
id={id}
ref={buttonRef}
type="button"
onClick={() => setOpen(!open)}
Expand Down
Loading