Repository navigation
Record window, first session rows and start-up phase times - #2900
Draft
nortonandreev wants to merge 3 commits into
Draft
nortonandreev wants to merge 3 commits into
nortonandreev wants to merge 3 commits into
Conversation
Times are taken from the kernel's process start, so runtime start-up counts too, and the window and rows marks wait for the compositor's Rendered signal rather than data or Show().
A frame still renders for a window hidden before it drew, and rows realized below folded groups are laid out without being on screen; neither now records a mark.
…wn (#2732) A compositor batch completes for a window hidden before it drew, so each attempt is voided by a hide and re-armed; a row counts only when its own bounds, not its list's, meet the viewport.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
Qodana for .NET11 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
This was referenced Nov 18, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2732 — AI-5622
What & why
app-lifecycle.jsonlhadapp_startedandtray_createdand nothing for what the user waits for. It now getswindow_shownandfirst_sessions_painted, each written once per process.startup_phasesrecords the durations of gate evaluation, graph build and window build. Each mark carriessince_start_ms, measured from the OS process start time, so a user's log shows where a slow start went.Where to look
RenderedFrame.WhenDrawn: a mark counts only a compositor frame drawn while the window stayed shown.first_sessions_paintedalso needs a laid-out row inside the rail's visible scroll area, not just an expanded group somewhere below it.Verification
Tart VM (macOS 26.6.2, 4 vCPU, 4 GB), local server 1.4.1,
tools/app-perf/coldstart.sh(#2896), 6 runs. The marks agree with OCR of a screenshot loop:window_shownfirst_sessions_paintedstartup_phasesRegression tests cover a window hidden before it renders, a viewport ending 1 px above the first row, and a group expanded below the viewport. Passing:
AppStartupTests30,MainWindowSmokeTests70,SessionRailFirstPaintSmokeTests4,RenderedFrameSmokeTests1,StartupMarksTests5.