Feedback on HTTP events - #188
Conversation
b7fd0f4 to
9da2492
Compare
9da2492 to
5a92ff0
Compare
5a92ff0 to
c4ea190
Compare
|
As for last PR I deployed to TestPyPI : python -m pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple multimodalsim-viewer==0.1.4.1 |
| document.body.appendChild(a); | ||
| a.click(); | ||
| document.body.removeChild(a); | ||
| window.URL.revokeObjectURL(url); |
There was a problem hiding this comment.
To prevent memory leak in case of error, wouldn't it be better to move revokeObjectURL into the the finally block?
| } | ||
|
|
||
| exportSimulation(simulationId: string, event: Event) { | ||
| async exportSimulation(simulationId: string, event: Event) { |
There was a problem hiding this comment.
Could the type hint Event be more specific? For example, is it always a MouseEvent?
There was a problem hiding this comment.
The type hinted by ESLint in the template is PointerEvent so I used it!
There was a problem hiding this comment.
Well apparently the compiler does not like PointerEvent so I used MouseEvent as you suggested!
pamun1
left a comment
pamun1
left a comment
There was a problem hiding this comment.
Sorry for the late review. Everything looks good to me. Please take a look at my (minor) suggestions in the comments. Let me know if you have any questions.
I applied you suggestion and merged! Thank you for your reviews! |
# Feedback on HTTP events (#188) ## Modifications - Add `SnackBarComponent` and `SnackBarService` to show error, warning, success and info snack bars easily. - Use new service for existing snack bar feedback. - Add loading and snackbar for : - Input data import, - Simulation import, - Simulation export, - Simulation delete.
2 participants
Feedback on HTTP events
To do
Modifications
SnackBarComponentandSnackBarServiceto show error, warning, success and info snack bars easily.