Improve tasks management - #197
Merged
Merged
Conversation
Collaborator
Author
|
I'll deploy a test version later to avoid having two concurrent features at a time being deployed. |
pamun1
reviewed
Oct 10, 2025
pamun1
reviewed
Oct 10, 2025
pamun1
requested changes
Oct 10, 2025
pamun1
left a comment
Collaborator
There was a problem hiding this comment.
The PR looks good overall. However, I noticed a potential logic bug in how the task priority is determined. Please take a look at my comments for more details.
pamun1
requested changes
Oct 16, 2025
pamun1
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the modifications. You’ve resolved many issues related to task priority. That's great! However, I believe there is still a minor problem with the condition for selecting the most urgent task. Please see my comment for more details.
3 tasks
Leo-Marbehan
force-pushed
the
feature/dyamic-task-time-allocation
branch
from
October 19, 2025 15:57
ecd41ea to
ce44f29
Compare
pamun1
approved these changes
Oct 27, 2025
pamun1
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the changes. Everything looks fine to me now.
Leo-Marbehan
force-pushed
the
feature/dyamic-task-time-allocation
branch
from
October 28, 2025 20:45
426313f to
eb88fa9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve tasks management
To do
MAX_STATES_EXTRACTION_CONCURRENT_TASKSvariable.Modifications
DEBUG_TASKSenvironment variable to enable debugging of tasks in the client.SimulationService.MAX_STATES_EXTRACTION_CONCURRENT_TASKSare currently being processed (10 by default).