Skip to content

fix: Stale api keys no longer display on the page once revoked#1925

Open
Vchen7629 wants to merge 3 commits into
mainfrom
stale-api-key-display-fix
Open

fix: Stale api keys no longer display on the page once revoked#1925
Vchen7629 wants to merge 3 commits into
mainfrom
stale-api-key-display-fix

Conversation

@Vchen7629

Copy link
Copy Markdown
Collaborator

Summary

Fixes #1877 , Updates the opensearch query to only fetch non revoked (revoked = False) api keys so the frontend recieves only non-revoked keys to display.

Demo (Before)

screen-capture.6.webm

Demo (After)

screen-capture.7.webm

Changes

  • updates api_key_service.py list_keys opensearch query to also filter for keys that have revoked set to false
  • Added a unit test to verify that query is sent correctly

@Vchen7629 Vchen7629 requested a review from NishadA05 June 18, 2026 20:18
@github-actions github-actions Bot added backend 🔷 Issues related to backend services (OpenSearch, Langflow, APIs) tests labels Jun 18, 2026
@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 49fb0ffd-ad51-49c4-b2c1-24be78f02ff5

📥 Commits

Reviewing files that changed from the base of the PR and between 89e0400 and 27dc424.

📒 Files selected for processing (2)
  • src/services/api_key_service.py
  • tests/unit/test_api_key_service.py
 _________________________________
< My bunny whiskers are tingling. >
 ---------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch stale-api-key-display-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the bug 🔴 Something isn't working. label Jun 18, 2026
@github-actions github-actions Bot added bug 🔴 Something isn't working. and removed bug 🔴 Something isn't working. labels Jun 18, 2026

@richardz403 richardz403 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Ran code locally, expired / revoked API keys no longer show up.

Ran tests locally, not issues found.

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details
{}

1 similar comment
@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details
{}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend 🔷 Issues related to backend services (OpenSearch, Langflow, APIs) bug 🔴 Something isn't working. tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Revoked api keys still display on the frontend

2 participants