fix: Stale api keys no longer display on the page once revoked#1925
fix: Stale api keys no longer display on the page once revoked#1925Vchen7629 wants to merge 3 commits into
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
richardz403
left a comment
There was a problem hiding this comment.
LGTM.
Ran code locally, expired / revoked API keys no longer show up.
Ran tests locally, not issues found.
|
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
1 similar comment
|
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
Summary
Fixes #1877 , Updates the opensearch query to only fetch non revoked (revoked = False) api keys so the frontend recieves only non-revoked keys to display.
Demo (Before)
screen-capture.6.webm
Demo (After)
screen-capture.7.webm
Changes
api_key_service.pylist_keys opensearch query to also filter for keys that have revoked set to false